Closed
Bug 1167607
Opened 9 years ago
Closed 9 years ago
Move AsyncEventDispatcher from using DispatchChromeEvent
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file, 2 obsolete files)
7.82 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Currently, AsyncEventDispatcher uses nsContentUtils::DispatchChromeEvent for chrome-only event. It could cause undesired behavior if the target is in chrome. We should make it use normal DispatchEvent method with mOnlyChromeDispatch flag set. As noted by :smaug, we should rename {a,e}DispatchChromeOnly to {a,e}OnlyChromeDispatch, and add comment to describe the behavior. This changes the current behavior of that class, but it seems to be fine based on test result from try server: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa5369bee7a2
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8609905 -
Flags: review?(bugs)
Assignee | ||
Comment 2•9 years ago
|
||
With the renaming, found some other place to change. The new try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=22327de3e9ff
Attachment #8609905 -
Attachment is obsolete: true
Attachment #8609905 -
Flags: review?(bugs)
Attachment #8609908 -
Flags: review?(bugs)
Assignee | ||
Comment 3•9 years ago
|
||
Add the fix for the failure on the bc1 test. New try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=84472593c13f
Attachment #8609908 -
Attachment is obsolete: true
Attachment #8609908 -
Flags: review?(bugs)
Attachment #8609941 -
Flags: review?(bugs)
Comment 4•9 years ago
|
||
Comment on attachment 8609941 [details] [diff] [review] patch >@@ -4237,17 +4237,17 @@ nsDocument::AddStyleSheetToStyleSets(nsI > init.memberName = argName; \ > \ > nsRefPtr<className> event = \ > className::Constructor(this, NS_LITERAL_STRING(type), init); \ > event->SetTrusted(true); \ > event->SetTarget(this); \ > nsRefPtr<AsyncEventDispatcher> asyncDispatcher = \ > new AsyncEventDispatcher(this, event); \ >- asyncDispatcher->mDispatchChromeOnly = true; \ >+ asyncDispatcher->mOnlyChromeDispatch = true; \ oh, tiny bit surprising code. I would have expected the event to have mOnlyChromeDispatch flag. But no need to change, not about this bug.
Attachment #8609941 -
Flags: review?(bugs) → review+
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/51b6ac207b1a
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•