1167614 - Re-enable (post experiment) Windows / OSX Core location provider on Nightly/Aurora

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[:garvan]

+++ This bug was initially created as a clone of Bug #1166773 +++

Revert the experiment from 1166773, that is, turn on native geo providers.

Comment 1

[:garvan]

[Tracking Requested - why for this release]: A reminder to reset the experiment in 1166773

To be clear, with or without 1166773, these changes only affect Nightly/Aurora experimental code. None of this affects Beta/Release.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

tracked. thanks

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Garvan, can we have a patch to disable it? (or I can ask for a backout of the patch which landed in bug 1166773)

Comment 4

[Hanno Schlichting]

We need a new patch for this, to only enable geo.provider.use_corelocation back again. Turns out the native Windows location provider is actually of lower quality than our MLS service.

Comment 5

[:garvan]

Attachment: bug1167614.diff

Comment 6

[Hanno Schlichting]

Comment on attachment 8627243 [details] [diff] [review]
bug1167614.diff

Review of attachment 8627243 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +1810,2 @@
>  #endif
>  

Isn't there one more #endif required for the new #ifdef? At least the original code had two endifs

Comment 7

[:garvan]

oops.
so... this is why you want travis ci :)

Comment 8

[:garvan]

Attachment: bug1167614.diff

Comment 9

[Hanno Schlichting]

Comment on attachment 8627249 [details] [diff] [review]
bug1167614.diff

Review of attachment 8627249 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it!

Comment 10

[:garvan]

The previous patch only turned on some functionality in Aurora+Nightly, this patch is the result of that experiment.

Hanno, agreed don't need this tracking 40 (Nightly is currently 42 BTW)? It can just land on Nightly.

Comment 11

[Hanno Schlichting]

Agreed, can just land on nightly. Our telemetry suggests that there is no significantly different user experience with core location on or off.

Comment 12

[:garvan]

Sorry, my fault, this shouldn't have been marked as tracking.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e93dcfa9b1b

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2e93dcfa9b1b