1167638 - Re-enable apps/system/test/marionette/software_home_fullscreen_layout_test.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

Disabled in bug 1167277.

Comment 1

[Kevin Grandon :kgrandon]

This failure happens in the test, 'While in requested fullscreen, toggles without reflow'. The stack looks like: 

 Error: timeout exceeded!
      at Object.Client.waitForSync (/Users/kevin/workspace/gaia/node_modules/marionette-client/lib/marionette/client.js:697:16)
      at Object.Client.waitFor (/Users/kevin/workspace/gaia/node_modules/marionette-client/lib/marionette/client.js:665:60)
      at Context.<anonymous> (/Users/kevin/workspace/gaia/apps/system/test/marionette/software_home_fullscreen_layout_test.js:92:12)


Etienne - could you take a look? I think this is a test that you introduced. Thanks!

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bub-1167638 > mozilla-b2g:master

Comment 3

[Etienne Segonzac (:etienne)]

So sad, it's a good test :)
I'll take a look, is there any cool new way to hunt intermittents with treeherder?

Comment 4

[Kevin Grandon :kgrandon]

(In reply to Etienne Segonzac (:etienne) from comment #3)
> So sad, it's a good test :)
> I'll take a look, is there any cool new way to hunt intermittents with
> treeherder?

Not really that I'm aware of =( If it works, feel free to land it and we can monitor after landing. It shouldn't be too bad now that we have retries in place.

Comment 5

[Etienne Segonzac (:etienne)]

Well, can't make it fail:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=4bb969b3bc6617d3c1a9b2a10eefd8901a6c0eaa&filter-searchStr=gaia%20opt%20Gaia%20javascript%20integration%20tests%20Marionette%20JS%20tests%20chunk%2019%20Gij%28Gij19%29

I'll wait for the tree to stabilize a bit then re-enable the test.

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8612930 [details] [review]
[gaia] etiennesegonzac:bub-1167638 > mozilla-b2g:master

Rebased, still solid :)

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8612930 [details] [review]
[gaia] etiennesegonzac:bub-1167638 > mozilla-b2g:master

Nice! Obviously, we should remove the `test.only` part from the final commit, but I'm glad to see this back.

Comment 8

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/7d1c6d5f7d9b27b30393fd26b611ea5148088c09

Comment 9

[Etienne Segonzac (:etienne)]

(In reply to Michael Henretty [:mhenretty] from comment #7)
> Comment on attachment 8612930 [details] [review]
> [gaia] etiennesegonzac:bub-1167638 > mozilla-b2g:master
> 
> Nice! Obviously, we should remove the `test.only` part from the final
> commit, but I'm glad to see this back.

almost missed it, thanks! :)