Closed Bug 1167682 Opened 9 years ago Closed 9 years ago

add talos tp4m and tsvgm files to ep1 repository

Categories

(Testing Graveyard :: Autophone, defect)

defect
Not set
normal

Tracking

(firefox41 affected)

RESOLVED FIXED
Tracking Status
firefox41 --- affected

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(2 files, 1 obsolete file)

      No description provided.
Attached file talos_ep1_ls.txt (obsolete) —
a ls -R of the files.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8609535 - Flags: feedback?(wlachance)
Attachment #8609535 - Flags: feedback?(bob)
Comment on attachment 8609535 [details]
talos_ep1_ls.txt

>talos/tp4m/amazon.com/ad.doubleclick.net/adi:
>amzn.us.gw.atf;sz=300x250;bn=507846;u=eea8630ee7eb403caeb104ee15e38be2;ord=1S4HFYTH8D43H8CW9SED;s=i0;s=i1;s=i2;s=i3;s=i5;s=i6;s=i7;s=i8;s=i9;s=1009;s=32;s=u1;s=u2;s=m4;s=m1;s=u10;s=u4;z=3;tile=1.html
>amzn.us.gw.btf;sz=300x250;bn=507846;u=ea1a9620885844dea31bb3e2035080b3;ord=1S4HFYTH8D43H8CW9SED;s=i0;s=i1;s=i2;s=i3;s=i5;s=i6;s=i7;s=i8;s=i9;s=1009;s=32;s=u10;s=m4;s=u4;s=m1;s=u2;s=u1;z=1;tile=3.html


File names like this are a pita and usually break adb pus. Can we rename them and replace the non-standard characters like ";" with "-" or "_" ?
If the webpage actually parses the path using the chars it might be a problem, but if it just loads them it shouldn't be.

You'll need to edit the files that reference them. 

>talos/tp4m/m.accuweather.com/b.scorecardresearch.com:
>p?c1=10&c2=6005068&c4=&cv=2.0&cj=1

ditto

>talos/tp4m/m.accuweather.com/core.ringleaderdigital.com/iserver:
>sr=1

I think = is ok.

>
>talos/tp4m/m.bbc.co.uk/www.bbc.co.uk/mobile/ic:
>mobile_PWUFLJao_822f783c-mobile*20110208162700.football|generic|ball|ap.jpg

bad chars... I don't think | is a good char. Maybe not * either.

>
>talos/tp4m/m.espn.com/ad.doubleclick.net/ad/N1823.espn.comSD2489:
>B5128878.6;sz=1x1;ord=2011.02.08.21.47.40

ditto

>
>talos/tp4m/m.espn.com/a.m.espn.go.com/wireless/mwImage/1/300/320/20/3:
>espnsource01c.starwave.com:9081

: bad?

>
>talos/tp4m/m.espn.com/w88.m.espn.go.com/b/ss/wdgespw/5.1:
>gjxtit9xe?D=..&c39=QQ&c36=OF&c38=1&gn=xhtml:home&c40=tmb-htc-g1android&c1=mw:espn&h1=top&c37=..User-Agent&r=..dimg-r-url&vid=gjxtit9x2058074211&v13=top:xhtml:home
>

bad chars

>talos/tp4m/m.yahoo.co.jp/yjaxc.yahoo.co.jp:
>oi?t=j&s=anemos_customkw00359&i=tct
>oi?t=j&s=ytop_ams_rmdl_utf8&i=toppage

bad chars

>
>talos/tp4m/m.yandex.ru/www.tns-counter.ru:
>V13a**4899731651297230936**yandex_ru

* bad?

Not sure if I got them all.

I would test by seeing if you can push this to a phone/device via adb.
Attachment #8609535 - Flags: feedback?(bob) → feedback-
Comment on attachment 8609535 [details]
talos_ep1_ls.txt

This looks reasonable except for the issue bc mentioned, which I'd also like to see addressed before this lands.
Attachment #8609535 - Flags: feedback?(wlachance) → feedback-
ok, cleaned up files names and greatly reduced directory structures.  Then I loaded the original pages and the newly modified pages, verified visually and via the console that we have the same stuff.  In the console there are errors, but they existing before :)  tp4m is now ~3Mb
Attachment #8609535 - Attachment is obsolete: true
Attachment #8610584 - Flags: feedback?(bob)
Comment on attachment 8610584 [details]
list of tp4m files in ep1/talos/tp4m

Looks good.
Attachment #8610584 - Flags: feedback?(bob) → feedback+
Comment on attachment 8610584 [details]
list of tp4m files in ep1/talos/tp4m

bc gave the thumbs up- lets see if you like it and I can land if all is good.
Attachment #8610584 - Flags: review?(wlachance)
Comment on attachment 8610584 [details]
list of tp4m files in ep1/talos/tp4m

Looks fine to me!
Attachment #8610584 - Flags: review?(wlachance) → review+
https://git.mozilla.org/?p=automation/ep1.git;a=commit;h=5d27c7bea7a97566b0f91e210b3068cc8d2844e0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: