1167693 - Strange AdapterHexIDs with spaces

Status: RESOLVED FIXED

Description

[Peter Bengtsson [:peterbe]]

Created attachment 8609552 [details]
Screenshot 2015-05-22 11.30.37.png

See, for example, this crash: https://crash-stats.mozilla.com/report/index/02a8cec2-88fc-4b65-b6da-ccf272150522

It has, under "App Notes"::

  AdapterVendorID: 0x10de, AdapterDeviceID: 0x fe9


This space means we can't ever find it a graphics adapter name for this. E.g. See "Graphics Adapter Report" tab on https://crash-stats.mozilla.com/report/list?product=Firefox&signature=mozilla%3A%3Aipc%3A%3ASerializeInputStream%28nsIInputStream*%2C+mozilla%3A%3Aipc%3A%3AInputStreamParams%26%2C+nsTArray%3Cmozilla%3A%3Aipc%3A%3AFileDescriptor%3E%26%29

Comment 1

[Kartikaya Gupta (away Jan 12-26; email:[e-mail])]

Apparently we have an API to spoof the adapter device ID: http://mxr.mozilla.org/mozilla-central/source/widget/nsIGfxInfoDebug.idl#14

It's possible some add-on or user has set this to a bad value. I'm not sure if it's worth trying to deal with this. WONTFIX?

Comment 2

[Ted Mielczarek [:ted] [:ted.mielczarek]]

This crash was from peterbe's computer, so feel free to ask him if he has something weird configured!

Comment 3

[Kartikaya Gupta (away Jan 12-26; email:[e-mail])]

^

Comment 4

[Peter Bengtsson [:peterbe]]

Kartikaya,

What's your question? I have add-ons installed. Several of them. None are called Screw-Up-The-Hex-Values :)

Comment 5

[Kartikaya Gupta (away Jan 12-26; email:[e-mail])]

Shoulda guessed it wouldn't be that obvious :)

If you start Firefox with a clean profile and trigger a crash, does the crash report still have the spaces in the AdapterHexIDs? Alternatively, if you have a build you can debug, stick a breakpoint at http://mxr.mozilla.org/mozilla-central/source/widget/cocoa/GfxInfo.mm?rev=f25e20a0f238#396 and see if it gets hit. If there's no spoofing happening, then I'd be interested in knowing if the value obtained at http://mxr.mozilla.org/mozilla-central/source/widget/cocoa/GfxInfo.mm?rev=f25e20a0f238#96 has the space, or if the space is somehow inserted afterwards. As far as I can tell there's no way this should be happening unless there's some spoofing going on.

Comment 6

[Peter Bengtsson [:peterbe]]

Here's another crash [0] I just made with 41.0a1 (2015-06-01). It has no extensions installed at all. 

[0] https://crash-stats.mozilla.com/report/index/ea292326-fda9-4804-8178-9f5132150601

Comment 7

[Kartikaya Gupta (away Jan 12-26; email:[e-mail])]

Created attachment 8613610 [details] [diff] [review]
Patch

Doh.

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 8613610 [details] [diff] [review]
Patch

Review of attachment 8613610 [details] [diff] [review]:
-----------------------------------------------------------------

nice

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c57b171813bf

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c57b171813bf