1167696 - Simplify nsTableReflowState

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Daniel Holbert [:dholbert]]

Noticed a few simplifications that can be made to nsTableReflowState:
 1) the prescontext arg on its methods is unused & can be removed.
 2) It's got 2 constructors, but only one of them is ever used -- so we can drop the unused one, and merge the used one into "Init()"

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: part 1: drop unused arg & constructor, and fold Init into remaining constructor

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 8609558 [details] [diff] [review]
part 1: drop unused arg & constructor, and fold Init into remaining constructor

It's weird to use "nsTableFrame&" when we use pointers for frames
everywhere else.  I think we should change it to "nsTableFrame*"
for consistency while we're here.

Comment 3

[Daniel Holbert [:dholbert]]

Ah, good point. Taking it one step further, we actually don't even need that nsTableFrame& (or nsTableFrame*) parameter at all, in fact -- we've already got it on the passed-in nsHTMLReflowState.

(I traced it back (just through one level of caller), and that nsHTMLReflowState comes from nsTableFrame::Reflow, so it should have its .frame member == this (the table frame) at that point. And '*this' is the frame that we pass in to construct the nsTableReflowState.)

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: part 2: drop frame arg, & get it from nsHTMLReflowState

(Since we're losing the type-enforcement of the passed-in frame having type nsTableFrame, I added an assertion about the frame's ->Type().)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4aa7021e13d
https://hg.mozilla.org/integration/mozilla-inbound/rev/3569f024ef47

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d4aa7021e13d
https://hg.mozilla.org/mozilla-central/rev/3569f024ef47