116773 - [FIX]Links, events, scripts shouldn't fire when user select an object

Status: RESOLVED FIXED

Description

[Chu Alan]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.7) Gecko/20011221
BuildID:    2001122108

I think it is okay to fire links, events, scripts etc. in the browser window,
but when user wants to select the element, these kind of stuffs shouldn't fire,
for example, when user wants to select a link element that will open a new
window, the new window shouldn't be opened.


Reproducible: Always
Steps to Reproduce:
1. open test case
2. try to select on those link elements



Actual Results:  all events, links, scripts etc. are fired, just like normal.


Expected Results:  these kind of stuffs shouldn't fire as user wants to select
elements only.

Comment 1

[Chu Alan]

Created attachment 62704 [details]
testcase

testcase for dom inspector.

Comment 2

[timeless]

ok, here's a much smaller testcase, the reporter is right, and actually editor 
has a similar problem.
Steps to play: click the url link, inspect the window, click the link to select 
it for inspection.
Expectation: Inspector displays information about the link.
Likely result: Window goes away.

Comment 3

[Chu Alan]

oh well ... the window goes away ... i haven't think of this, may be this is not
just an enhancement than ?

Comment 4

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Created attachment 93954 [details] [diff] [review]
call preventDefault() and stopPropagation() a lot.

Comment 5

[John Keiser (jkeiser)]

Comment on attachment 93954 [details] [diff] [review]
call preventDefault() and stopPropagation() a lot.

r=jkeiser if you prevent mousedown in MouseDownListener too--not that I'm a DOM
Inspector hacker, but I am an events hacker :)	Also note that there is dead
code in MouseDownListener (the "mouseover" case), may want to remove that if
hewitt wants.

This doesn't prevent onmouseover and onmousemove, but unless we are really
trying to prevent all JS from happening (which I don't think we are), this
should deal with the common cases (most of which happen on click, the worst of
which is <A HREF>).

Comment 6

[Boris Zbarsky [:bzbarsky, bz on IRC]]

taking

Comment 7

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Created attachment 93961 [details] [diff] [review]
patch with jkeiser's comment addressed

Comment 8

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Comment on attachment 93961 [details] [diff] [review]
patch with jkeiser's comment addressed

marking r=jkeiser

Comment 9

[Joe Hewitt (gone)]

Comment on attachment 93961 [details] [diff] [review]
patch with jkeiser's comment addressed

sr=hewitt

Comment 10

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Fix checked in.