1167756 - INFO TEST-UNEXPECTED-FAIL | browser/components/uitour/test/browser_UITour_pocket.js | leaked window property: AppConstants - expected PASS

Status: RESOLVED FIXED

(Firefox :: Pocket, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

We are leaking the AppConstants property in browser/components/pocket/main.js.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Only showed up in beta builds, wasn't seen in aurora or nightly. It wasn't seen in aurora because Pocket is disabled on aurora. It wasn't seen on release because the patch that introduced it didn't make it to release (bug 1164942). We aren't sure why it wasn't seen on nightly.

Comment 2

[Matthew N. [:MattN]]

Attachment: v.1 Beta patch - Switch to openUILink for the Pocket menubar item to avoid using and leaking AppConstants

Comment 3

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d13593be924c

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7188ec67731b

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8609620 [details] [diff] [review]
v.1 Beta patch - Switch to openUILink for the Pocket menubar item to avoid using and leaking AppConstants

Approval Request Comment
[Feature/regressing bug #]: Pocket leak caused by bug 1164942 somehow
[User impact if declined]: Probably none but the leak will appear when Pocket is enabled on the branch.
[Describe test coverage new/current, TreeHerder]: I manually tested the menu item on OS X
[Risks and why]: Low risk change related to OS X where there are no open Browser Windows.
[String/UUID change made/needed]: None

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7188ec67731b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8609620 [details] [diff] [review]
v.1 Beta patch - Switch to openUILink for the Pocket menubar item to avoid using and leaking AppConstants

Let's get a retroactive beta approval here too for perpetuity. Note that it was already landed a=bustage anyway, though.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b500a8efdc29