Closed
Bug 1167756
Opened 9 years ago
Closed 9 years ago
INFO TEST-UNEXPECTED-FAIL | browser/components/uitour/test/browser_UITour_pocket.js | leaked window property: AppConstants - expected PASS
Categories
(Firefox :: Pocket, defect)
Firefox
Pocket
Tracking
()
People
(Reporter: jaws, Assigned: MattN)
Details
Attachments
(1 file)
3.57 KB,
patch
|
jaws
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We are leaking the AppConstants property in browser/components/pocket/main.js.
Flags: qe-verify-
Flags: firefox-backlog+
Reporter | ||
Comment 1•9 years ago
|
||
Only showed up in beta builds, wasn't seen in aurora or nightly. It wasn't seen in aurora because Pocket is disabled on aurora. It wasn't seen on release because the patch that introduced it didn't make it to release (bug 1164942). We aren't sure why it wasn't seen on nightly.
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8609620 -
Flags: review?(jaws)
Reporter | ||
Updated•9 years ago
|
Attachment #8609620 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/d13593be924c
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8609620 [details] [diff] [review] v.1 Beta patch - Switch to openUILink for the Pocket menubar item to avoid using and leaking AppConstants Approval Request Comment [Feature/regressing bug #]: Pocket leak caused by bug 1164942 somehow [User impact if declined]: Probably none but the leak will appear when Pocket is enabled on the branch. [Describe test coverage new/current, TreeHerder]: I manually tested the menu item on OS X [Risks and why]: Low risk change related to OS X where there are no open Browser Windows. [String/UUID change made/needed]: None
Attachment #8609620 -
Flags: approval-mozilla-aurora?
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7188ec67731b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment 7•9 years ago
|
||
Comment on attachment 8609620 [details] [diff] [review] v.1 Beta patch - Switch to openUILink for the Pocket menubar item to avoid using and leaking AppConstants Let's get a retroactive beta approval here too for perpetuity. Note that it was already landed a=bustage anyway, though.
Attachment #8609620 -
Flags: approval-mozilla-beta?
Updated•9 years ago
|
Attachment #8609620 -
Flags: approval-mozilla-beta?
Attachment #8609620 -
Flags: approval-mozilla-beta+
Attachment #8609620 -
Flags: approval-mozilla-aurora?
Attachment #8609620 -
Flags: approval-mozilla-aurora+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b500a8efdc29
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•