Closed Bug 1167784 Opened 8 years ago Closed 8 years ago

Make history section headings dynamic

Categories

(Firefox for iOS :: Home screen, defect)

Product:
Firefox for iOS
Component:
Home screen
Platform:
All
iOS 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file)

Pull-to-refresh and fix swipe-to-delete
47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review 
Sections aren't supposed to be empty. That means if you remove the last history item in a section (e.g., "Today"), we crash.
I think the first two commits have been reviewed.
Attachment #8609691 - Flags: review?(bnicholson)
Comment on attachment 8609691 [details] [review]
Pull-to-refresh and fix swipe-to-delete

Haven't tested yet, but looks fine.
Attachment #8609691 - Flags: review?(bnicholson) → review+
https://github.com/mozilla/firefox-ios/commit/5e58ecaa6d176b054c5d5e900be2784b441aec37
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.