Setting gfx.xrender.enable to false crashes on startup

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
mozilla42
Points:
---

Firefox Tracking Flags

(firefox41 affected, firefox42 fixed)

Details

Attachments

(1 attachment)

We get an error in X_PutShmImage because we try to do a Put of an image to fill the entire window, when the image is the wrong size (too small).

Restricting the invalid region to the bounds of the image fixes the bug and the browser works OK apart from one or a few glitches during startup.
Comment on attachment 8609652 [details] [diff] [review]
bug1167786

I don't know why EndRemoteDrawingInRegion() is providing a region greater than the size found in StartRemoteDrawing(), so there may be some unnecessary painting happening somewhere, but this change provides a sensible interpretation of this function's parameters.
Attachment #8609652 - Flags: review?(karlt) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/fe452120866e9a66ea70ba1089ac6b3d2164d676
changeset:  fe452120866e9a66ea70ba1089ac6b3d2164d676
user:       Robert O'Callahan <robert@ocallahan.org>
date:       Tue Jul 14 00:03:44 2015 +1200
description:
Bug 1167786. Restrict bounds of drawn region to the nsShmImage bounds to avoid X errors. r=karlt
https://hg.mozilla.org/mozilla-central/rev/fe452120866e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.