1167789 - The string "inline" is stripped out of a copied string from rule view

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Brian Grinstead [:bgrins]]

STR:
* Open this page: data:text/html,<span style="display:inline;">You feeling lucky?  Try to copy my display value</span>
* Highlight 'inline' or 'inline;'
* Copy the string via context menu or keyboard shortcut

Expected
That 'inline;' will be on the clipboard

Actual
';' is on the clipboard

Comment 1

[Julian Descottes [:jdescottes]]

Bug triage. Filter on CLIMBING SHOES

Confirmed on FF48.

"inline" is explicitly removed from the copied text here:
https://hg.mozilla.org/mozilla-central/file/29d5a4175c8b/devtools/client/inspector/rules/rules.js#l477

We need to check if this code is actually needed. I think it is just a leftover that was not removed by https://hg.mozilla.org/mozilla-central/rev/2149897d05a0.
This code seems to strip the "inline" as the source of a rule, but sources are no longer included in the selected & copied text. The commit mentioned above removed all the logic that used to strip patterns such as "myfile.css:12".

The goal here would be to remove the deprecated code, and possibly add a test.

Comment 2

[Maximillian von Briesen [:moby]]

Attachment: inline-copy.patch

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8760342 [details] [diff] [review]
inline-copy.patch

Review of attachment 8760342 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me if try is green https://treeherder.mozilla.org/#/jobs?repo=try&revision=eaeb750bece5

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/580436387d62
Do not remove 'inline' from copied text in the style editor; r=bgrins

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/580436387d62

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/580436387d62

Comment 7

[Kazi Nuzhat Tasnem]

I have reproduced this bug with Firefox nightly 41.0a1(build id:20150522030225)on
windows 7(64 bit)

I have verified this bug fixed with Firefox aurora 50.0a2(build id:20160817004002)
User Agent:Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0

[bugday-20160817]