Closed
Bug 1167892
Opened 9 years ago
Closed 9 years ago
Switch to 1.1dppx for Windows HDPI implementation in devtools
Categories
(DevTools :: General, defect)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: ntim, Assigned: c0mrad3, Mentored)
References
Details
(Whiteboard: [good first bug][lang=css])
Attachments
(2 files)
27.00 KB,
patch
|
ntim
:
review+
pbro
:
review+
|
Details | Diff | Splinter Review |
27.01 KB,
patch
|
c0mrad3
:
review+
|
Details | Diff | Splinter Review |
So, the desktop team changed their implementation once again, to use 1.1dppx. We should do that as well.
Reporter | ||
Comment 1•9 years ago
|
||
We basically want to batch replace 1.25dppx to 1.1dppx in browser/themes/shared/devtools and in browser/devtools
Whiteboard: [good first bug][lang=css]
Reporter | ||
Updated•9 years ago
|
Mentor: ntim.bugs
Hey Tim! This is my first bug. I would like to try this one. Could you assign this one to me?
Updated•9 years ago
|
Assignee: nobody → mtjvankuik
Reporter | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Updated•9 years ago
|
Assignee: mtjvankuik → nobody
Status: ASSIGNED → NEW
Assignee | ||
Comment 3•9 years ago
|
||
I would like to work on this bug :) what should I grep -r '1.25dppx' -n --with-filename change all the 1.25dppx with 1.1dppx ? in the given output of command
Flags: needinfo?(ntim.bugs)
Reporter | ||
Comment 4•9 years ago
|
||
(In reply to Tummala Dhanvi from comment #3) > I would like to work on this bug :) > > what should I > > grep -r '1.25dppx' -n --with-filename > > change all the 1.25dppx with 1.1dppx ? in the given output of command Yep, we want to change 1.25dppx to 1.1dppx. We should do it in the browser/devtools and browser/themes/shared/devtools folders.
Flags: needinfo?(ntim.bugs)
Assignee | ||
Comment 5•9 years ago
|
||
So I could just use $ sed -i -e 's/1.25dppx/1.1dppx/g' * on both the directories browser/devtools and browser/themes/shared/devtools and send a patch to you (English is not my native language so just making things clear) Also can you assign this bug to me ? I will send you a patch as soon as possible
Flags: needinfo?(ntim.bugs)
Reporter | ||
Comment 6•9 years ago
|
||
(In reply to Tummala Dhanvi from comment #5) > So I could just use > > $ sed -i -e 's/1.25dppx/1.1dppx/g' * > > on both the directories browser/devtools and browser/themes/shared/devtools > and send a patch to you Yep. > (English is not my native language so just making things clear) No worries, it's not mine either ;) > Also can you assign this bug to me ? I will send you a patch as soon as > possible Sure
Assignee: nobody → dhanvicse
Flags: needinfo?(ntim.bugs)
Reporter | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•9 years ago
|
||
Reporter | ||
Comment 8•9 years ago
|
||
Comment on attachment 8646337 [details] [diff] [review] Bug-1167892.patch Review of attachment 8646337 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me !
Attachment #8646337 -
Flags: review+
Reporter | ||
Updated•9 years ago
|
Attachment #8646337 -
Flags: review?(pbrosset)
Comment 9•9 years ago
|
||
Comment on attachment 8646337 [details] [diff] [review] Bug-1167892.patch Review of attachment 8646337 [details] [diff] [review]: ----------------------------------------------------------------- Thanks ntim for mentoring and reviewing this bug. R+ for me too if ntim is happy (although Tim is unfortunately not a peer yet, so could you change the commit message to be: Bug 1167892 - Switch to 1.1dppx for Windows HDPI implementation in devtools r=ntim r=pbro Thanks).
Attachment #8646337 -
Flags: review?(pbrosset) → review+
Assignee | ||
Comment 10•9 years ago
|
||
Added r=pbro as in the above comment
Attachment #8646460 -
Flags: review+
Reporter | ||
Comment 11•9 years ago
|
||
Thanks ! I've set the checkin-needed flag so the patch will get checked in into the source. Once the patch reaches mozilla-central, it'll appear on the next day's nightly. Patrick, thanks for the review !
Keywords: checkin-needed
Comment 12•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/3945e72b7fbe
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/3945e72b7fbe
Whiteboard: [good first bug][lang=css] → [good first bug][lang=css][fixed-in-fx-team]
Comment 14•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3945e72b7fbe
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=css][fixed-in-fx-team] → [good first bug][lang=css]
Target Milestone: --- → Firefox 43
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•