1167937 - test_doc_busy.html attempts to install an empty XPI file, leaving behind a popup notification that interferes with other tests

Status: NEW

(Core :: Disability Access APIs, defect, P3)

Description

[Dão Gottwald [:dao]]

Attachment: screenshot

See bug 1167716 comment 8.

It's unclear what kind of addon that is, maybe the "mochitests" origin displayed in the popup notification is an indication to someone.

Comment 1

[Dave Townsend [:mossop]]

Looks like this test attempts to install an empty XPI file: http://mxr.mozilla.org/mozilla-central/source/accessible/tests/mochitest/states/test_doc_busy.html?raw=1

Comment 2

[alexander :surkov (:asurkov)]

This test tests a11y behavior when the user requests to load a file. What are concerns?

Comment 3

[Dave Townsend [:mossop]]

The doorhanger remains onscreen after the test which can affect later tests

Comment 4

[alexander :surkov (:asurkov)]

(In reply to Dave Townsend [:mossop] from comment #3)
> The doorhanger remains onscreen after the test which can affect later tests

so if there's no other concerns then I assume generated escape key should do a trick?

Comment 5

[Dão Gottwald [:dao]]

You probably shouldn't use an XPI file in the first place if you just want to test the behavior of "downloading files".

Comment 6

[alexander :surkov (:asurkov)]

(In reply to Dão Gottwald [:dao] from comment #5)
> You probably shouldn't use an XPI file in the first place if you just want
> to test the behavior of "downloading files".

This also should work. Iirc we test here the document's busy state, i.e. when the user clicks on a link, we listen for events that the document gets busy and then it gets not busy. So probably not every file type will do same job.

Comment 7

[Dão Gottwald [:dao]]

I just hit this again with a completely different and innocent patch, so I'm gonna disable this test on 10.6 for the time being.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/707f94ce1881

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/707f94ce1881

Comment 10

[Marco Zehe (:MarcoZ)]

Dão, can this be closed?

Comment 11

[Dão Gottwald [:dao]]

This test is likely still broken.

Comment 12

[James Teh [:Jamie]]

This test was changed in bug 1004061 to use a zip instead of an XPI. However, that still brought up the download dialog and didn't close it.

I rewrote this test in bug 1626851 so that it closes the download dialog after it finishes, which should deal with this problem. Unfortunately, now we're hitting an intermittent timeout, bug 1647666, which I'm still trying to resolve.