Closed
Bug 1167962
Opened 9 years ago
Closed 9 years ago
Keep exports at bottom of modules
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox40 fixed, firefox41 fixed)
RESOLVED
FIXED
Firefox 41
People
(Reporter: vporof, Assigned: vporof)
References
Details
Attachments
(1 file)
26.28 KB,
patch
|
jsantell
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
I propose keeping export assignments at the bottom of files. As it is it's hard for me to glance over a file and see exactly what's exported.
Assignee | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8609869 [details] [diff] [review] v1 Review of attachment 8609869 [details] [diff] [review]: ----------------------------------------------------------------- This scares me as something to land this week unless it'll be fine debasing against
Attachment #8609869 -
Flags: review?(jsantell) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2) > Comment on attachment 8609869 [details] [diff] [review] > v1 > > Review of attachment 8609869 [details] [diff] [review]: > ----------------------------------------------------------------- > > This scares me as something to land this week unless it'll be fine debasing > against No names are changed, just the position of some lines. Shouldn't be a problem for rebasing.
Assignee | ||
Updated•9 years ago
|
Blocks: perf-40-uplifts
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f7fc319b75f1 https://hg.mozilla.org/mozilla-central/rev/deb6cdd0a7fa
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Updated•9 years ago
|
Flags: qe-verify-
Comment 7•9 years ago
|
||
Comment on attachment 8609869 [details] [diff] [review] v1 Approval Request Comment [Feature/regressing bug #]: 1167252, the new performance tool [User impact if declined]: Won't ship the performance tool [Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift [Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel. [String/UUID change made/needed]: None
Attachment #8609869 -
Flags: approval-mozilla-aurora?
Comment 8•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/76a2777f3268 https://hg.mozilla.org/releases/mozilla-aurora/rev/f523187a627a
status-firefox40:
--- → fixed
Comment 9•9 years ago
|
||
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment 10•9 years ago
|
||
Comment on attachment 8609869 [details] [diff] [review] v1 Change approved to skip one train as part of the spring campaign.
Attachment #8609869 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•