Closed Bug 1167967 Opened 9 years ago Closed 9 years ago

Memory allocations tree render() has an extra unnecessary options argument

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set
normal

Tracking

(firefox40 fixed, firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(1 file)

Furthermore, the options object is populated and modified every time it's passed inside a function. This is terribly confusing.

Same thing was being done in the profiler tree details view, but Jordan made it nicer. This patch does the same thing for the memory tree.
Attached patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8609873 - Flags: review?(jsantell)
Comment on attachment 8609873 [details] [diff] [review]
v1

Review of attachment 8609873 [details] [diff] [review]:
-----------------------------------------------------------------

Make sure to tag all these patches with perf-40-uplifts for bgrins
Attachment #8609873 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/9f0c882a529f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Flags: qe-verify-
Comment on attachment 8609873 [details] [diff] [review]
v1


Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake.  Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None
Attachment #8609873 - Flags: approval-mozilla-aurora?
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+.  See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment on attachment 8609873 [details] [diff] [review]
v1

Change approved to skip one train as part of the spring campaign.
Attachment #8609873 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.