Closed Bug 1167979 Opened 5 years ago Closed 5 years ago

Remove SpiderMonkey specific JS syntax in devtools/webconsole

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: pbro, Assigned: pbro)

References

Details

Attachments

(1 file)

From bug 887895:

 webconsole/hudservice.js:323:37
  Unexpected identifier

  webconsole/panel.js:106:16
  Unexpected token this

  webconsole/test/browser_console_variables_view_dont_sort_non_sortable_classes_properties.js:89:30
  Illegal yield expression

  webconsole/test/browser_console_variables_view_highlighter.js:49:27
  Unexpected token for

  webconsole/test/browser_netpanel_longstring_expand.js:140:9
  Unexpected identifier

  webconsole/test/browser_webconsole_autocomplete-properties-with-non-alphanumeric-names.js:23:10
  Illegal yield expression

  webconsole/test/browser_webconsole_autocomplete_in_debugger_stackframe.js:39:9
  Unexpected identifier

  webconsole/test/browser_webconsole_bug_578437_page_reload.js:13:18
  Unexpected token

  webconsole/test/browser_webconsole_cd_iframe.js:106:11
  Unexpected identifier

  webconsole/test/browser_webconsole_history.js:26:7
  Unexpected identifier

  webconsole/test/browser_webconsole_jsterm.js:46:9
  Unexpected identifier

  webconsole/test/browser_webconsole_network_panel.js:108:9
  Unexpected identifier

  webconsole/test/browser_webconsole_split.js:53:13
  Unexpected identifier

  webconsole/test/browser_webconsole_split_escape_key.js:115:25
  Unexpected identifier

  webconsole/webconsole.js:246:18
  Unexpected token this
Assignee: nobody → pbrosset
Blocks: 887895
Status: NEW → ASSIGNED
Depends on: 1167945
Blocks: 1168077
Comment on attachment 8609887 [details] [diff] [review]
bug1167979-spidermonkey-webconsole.diff

Review of attachment 8609887 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8609887 - Flags: review?(bgrinstead) → review+
https://hg.mozilla.org/mozilla-central/rev/4a14148749dd
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.