Closed Bug 1167982 Opened 4 years ago Closed 3 months ago
Thunderbird misencodes "git format-patch" attachments with UTF-8; should add charset=UTF-8 to Content-Type: text/x-patch
14.50 KB, text/plain
8.27 KB, text/plain
2.01 KB, text/plain
998 bytes, patch
|Details | Diff | Splinter Review|
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Build ID: 20150511103303 Steps to reproduce: I ran 'git format-patch' on a repository that uses UTF-8 encoding, and attached to my outgoing mail the resulting .patch file, which contained some UTF-8 characters. (I've attached this .patch file to this bug report.) Actual results: Thunderbird creates a .patch attachment with a header that says "Content-Type: text/x-patch;" with no charset attribute. Expected results: The header should say "Content-Type: text/x-patch; charset=UTF-8;". This bug has caused problems for people trying to read my email with non-Thunderbird clients. For details, please see: http://lists.gnu.org/archive/html/emacs-devel/2015-05/msg00710.html
Dmitry Gutov reports in the abovementioned thread on emacs-devel that the bug also occurs in Thunderbird 38 (beta).
Version: 31 → 38
Summary: Thunderbird misencodes "git format-patch" attachments with UTF-8 → Thunderbird misencodes "git format-patch" attachments with UTF-8; should add charset=UTF-8 to Content-Type: text/x-patch
Assignee: nobody → benjamin
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 8609888 [details] 0045-Prefer-this-to-this-in-doc-strings.patch This appears to be test data, so a sample patch that when attached in TB causes the problem.
Attachment #8609888 - Attachment is obsolete: false
Attachment #9064232 - Attachment mime type: message/rfc822 → text/plain
Comment on attachment 9065250 [details] [diff] [review] 1167982.patch Review of attachment 9065250 [details] [diff] [review]: ----------------------------------------------------------------- Patch works.I sent and received several patches that were affected before. Issue appears fixed.
Attachment #9065250 - Flags: feedback?(benjamin) → feedback+
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Assignee: benjamin → jorgk
Target Milestone: --- → Thunderbird 68.0
Pushed by email@example.com: https://hg.mozilla.org/comm-central/rev/c7bb9e23894a Follow-up: Adjust test to charset detection for text/* attachments. r=me
You need to log in before you can comment on or make changes to this bug.