1168035 - [Stingray][Dashboard] Support key navigation betwen dashboard and inside widget.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

When expanding the widget, we have to move focus into widget.
When shrinking the widget, we have to move focus back to dashboard.

Specifically, Once user presses right, the right widget should got the focus; and lose it when user press left to go back.

We may need to use onbeforekeydown to achieve this.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] rexboy7:1168035-focus-on-widget > mozilla-b2g:master

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

John may you review this patch? You can send it to Yifan if you feel necessary. Thanks!

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8610527 [details] [review]
patch

Looks good to me. I had left some issues at PR.

BTW, it would be nice to have the following two things:
1. add focus handling at weather-widget to move between those two timezone.
2. add integration test to test the focus change.

Once we have focus handling at weather-widget, we can have a test to send left, right key events to the widget iframe and to check if the focus is changed.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Please rebase to master to have gij-tv displayed on your tree herder tests.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Since weather-widget doesn't have any focusable elements by design, if we adds focus handling on it, they would be purely developing/demo purpose. So I tend to do it later.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8610527 [details] [review]
patch

I have some changes specified for mozbeforekey/mozafterkey events. The changes are not very major but I think they need a second review. I put my modifications on the second commit.
John would you mind reviewing them again? Thank you!

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8610527 [details] [review]
patch

looks good to me.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thank you John!

master
https://github.com/mozilla-b2g/gaia/commit/7b2b3fedbc6304488dca05e617e99e758a66443b