Closed
Bug 1168044
Opened 11 years ago
Closed 11 years ago
[gaia-dialog] based on gaia-component
Categories
(Firefox OS Graveyard :: Gaia::Components, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gasolin, Assigned: gasolin)
References
Details
Attachments
(1 external file)
Make gaia-dialog(s) created via gaia-component module.
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•11 years ago
|
||
* use gaia-component to wrap all gaia-dialogs
* wrap styles with ::content and :host
* add basic lint check
* travis CI integration
Attachment #8612116 -
Flags: review?(wilsonpage)
Comment 2•11 years ago
|
||
Comment on attachment 8612116 [details] [review]
pull request redirect to github
Looks good, nice work, a lot cleaner :)
Some comments inline regarding:
- RTL
- Fixing an animation glitch
- Missing padding on example page
Attachment #8612116 -
Flags: review?(wilsonpage) → review+
Comment 3•11 years ago
|
||
fred: Can you fix the comments so we can land this?
I also noticed we need to:
- Delete `src/`
- Delete `<link rel="import" ...` line from `index.html`
Updated•11 years ago
|
Flags: needinfo?(gasolin)
| Assignee | ||
Comment 4•11 years ago
|
||
Thanks for reminding. I've addressed comments from github and remove redundant resources.
Please kindly check it again.
Flags: needinfo?(gasolin)
Comment 5•11 years ago
|
||
LANDED https://github.com/gaia-components/gaia-dialog/commit/8997e476ff67d8185edb5204bbfed1ac9a4dc8ba
STAMPED https://github.com/gaia-components/gaia-dialog/releases/tag/v0.1.0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•