Closed Bug 1168044 Opened 11 years ago Closed 11 years ago

[gaia-dialog] based on gaia-component

Categories

(Firefox OS Graveyard :: Gaia::Components, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(1 external file)

Make gaia-dialog(s) created via gaia-component module.
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
* use gaia-component to wrap all gaia-dialogs * wrap styles with ::content and :host * add basic lint check * travis CI integration
Attachment #8612116 - Flags: review?(wilsonpage)
Comment on attachment 8612116 [details] [review] pull request redirect to github Looks good, nice work, a lot cleaner :) Some comments inline regarding: - RTL - Fixing an animation glitch - Missing padding on example page
Attachment #8612116 - Flags: review?(wilsonpage) → review+
fred: Can you fix the comments so we can land this? I also noticed we need to: - Delete `src/` - Delete `<link rel="import" ...` line from `index.html`
Flags: needinfo?(gasolin)
Thanks for reminding. I've addressed comments from github and remove redundant resources. Please kindly check it again.
Flags: needinfo?(gasolin)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: