Closed Bug 1168052 Opened 10 years ago Closed 10 years ago

FFmpeg's decoder(PDM) should handle the errors happening during draining.

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Version:
37 Branch
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: bwu, Unassigned)

Details

Current FFmpeg's decoder looks like to ignore those errors happening during draining and it still call DrainComplete even some errors happen. We should report the error by calling Error() and not call DrainComplete.
it's not ffmpeg, its all decoders. calling DrainComplete() regardless is the proper way to do it, without having to change it all
(In reply to Jean-Yves Avenard [:jya] from comment #1) > it's not ffmpeg, its all decoders. Yeah. I noticed after checking other PDM codes. > > calling DrainComplete() regardless is the proper way to do it, without > having to change it all. Although it is not a critical bug and doesn't cause problems now, I think we still need to make it right.
Component: Audio/Video → Audio/Video: Playback
there's nothing to do here.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.