Closed Bug 1168077 Opened 5 years ago Closed 5 years ago

Remove remaining SpiderMonkey specific JS syntax in browser/devtools

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: pbro, Assigned: pbro)

References

Details

Attachments

(1 file)

From bug 887895, and looking at its blocking bugs, the remaining offenders in browser/devtools should be:

tilt
====

  tilt/tilt-gl.js:838:11
  Unexpected identifier

webaudioeditor
==============

  webaudioeditor/panel.js:55:16
  Unexpected token this

  webaudioeditor/test/browser_wa_properties-view-edit-01.js:60:11
  Unexpected identifier

sourceeditor
============

  sourceeditor/editor.js:85:54
  Unexpected token for

storage
=======

  storage/panel.js:34:16
  Unexpected token this

netmonitor
==========

  netmonitor/netmonitor-controller.js:371:16
  Unexpected identifier

  netmonitor/netmonitor-view.js:951:30
  Unexpected token (

  netmonitor/panel.js:59:16
  Unexpected token this

  netmonitor/test/browser_net_complex-params.js:20:13
  Unexpected identifier

  netmonitor/test/browser_net_simple-request-details.js:18:13
  Unexpected identifier

  netmonitor/test/head.js:408:49
  Unexpected token for

commandline
===========

  commandline/test/browser_cmd_screenshot.js:29:23
  Unexpected identifier
Assignee: nobody → pbrosset
Blocks: 887895
Status: NEW → ASSIGNED
+ all the tests in browser/devools/performance/test that miss the * for the spawTest generator function.
+ things in shadereditor too.
Depends on: 1167979
Comment on attachment 8610097 [details] [diff] [review]
bug1168077-spidermonkey-remaining-browser-devtools.diff

https://treeherder.mozilla.org/#/jobs?repo=try&revision=315440d4ea04
Attachment #8610097 - Flags: review?(mratcliffe)
Attachment #8610097 - Flags: review?(mratcliffe) → review+
https://hg.mozilla.org/mozilla-central/rev/30945769c039
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.