Closed
Bug 1168077
Opened 9 years ago
Closed 9 years ago
Remove remaining SpiderMonkey specific JS syntax in browser/devtools
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox41 fixed)
RESOLVED
FIXED
Firefox 41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: pbro, Assigned: pbro)
References
Details
Attachments
(1 file)
168.09 KB,
patch
|
miker
:
review+
|
Details | Diff | Splinter Review |
From bug 887895, and looking at its blocking bugs, the remaining offenders in browser/devtools should be: tilt ==== tilt/tilt-gl.js:838:11 Unexpected identifier webaudioeditor ============== webaudioeditor/panel.js:55:16 Unexpected token this webaudioeditor/test/browser_wa_properties-view-edit-01.js:60:11 Unexpected identifier sourceeditor ============ sourceeditor/editor.js:85:54 Unexpected token for storage ======= storage/panel.js:34:16 Unexpected token this netmonitor ========== netmonitor/netmonitor-controller.js:371:16 Unexpected identifier netmonitor/netmonitor-view.js:951:30 Unexpected token ( netmonitor/panel.js:59:16 Unexpected token this netmonitor/test/browser_net_complex-params.js:20:13 Unexpected identifier netmonitor/test/browser_net_simple-request-details.js:18:13 Unexpected identifier netmonitor/test/head.js:408:49 Unexpected token for commandline =========== commandline/test/browser_cmd_screenshot.js:29:23 Unexpected identifier
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
+ all the tests in browser/devools/performance/test that miss the * for the spawTest generator function.
Assignee | ||
Comment 2•9 years ago
|
||
+ things in shadereditor too.
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8610097 [details] [diff] [review] bug1168077-spidermonkey-remaining-browser-devtools.diff https://treeherder.mozilla.org/#/jobs?repo=try&revision=315440d4ea04
Attachment #8610097 -
Flags: review?(mratcliffe)
Attachment #8610097 -
Flags: review?(mratcliffe) → review+
https://hg.mozilla.org/mozilla-central/rev/30945769c039
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•