1168156 - Remove unused nsCSSValueTokenStream::mSheet

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=761267c360be

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Remove unused nsCSSValueTokenStream::mSheet

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8610182 [details] [diff] [review]
Remove unused nsCSSValueTokenStream::mSheet

Review of attachment 8610182 [details] [diff] [review]:
-----------------------------------------------------------------

Bug 952338 is open on restoring the mSheet argument to ParsePropertyWithVariableReferences in nsRuleNode::ResolveVariableReferences.  I guess it's OK to remove in the meantime, though.  Although generally commenting out code isn't great, I think it'd be fine here (particularly because in the case mentioned in bug 952338 the pointer can actually be bad).  Can you comment out those three lines and add a "// XXX Should store sheet here (see bug 952338)." comment on them?

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Remove unused nsCSSValueTokenStream::mSheet

Add comments mentioning Bug 952338.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6e5da6c4a35

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d6e5da6c4a35