1168158 - Make URLValue::mString a smart pointer

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=761267c360be

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Make URLValue::mString a smart pointer

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8610183 [details] [diff] [review]
Make URLValue::mString a smart pointer

Review of attachment 8610183 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/nsCSSValue.cpp
@@ +2340,4 @@
>  }
>  
>  css::URLValue::~URLValue()
> +{}

May as well remove the definition and put it inline in nsCSSValue.h.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Make URLValue::mString a smart pointer

Move URLValue::~URLValue inline into the header

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eff5410a0db3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eff5410a0db3