Closed Bug 1168158 Opened 8 years ago Closed 8 years ago

Make URLValue::mString a smart pointer

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: nika, Assigned: nika)

Details

Attachments

(1 file, 1 obsolete file)

Make URLValue::mString a smart pointer
2.80 KB, patch
Details | Diff | Splinter Review
Attachment #8610183 - Flags: review?(cam)
Comment on attachment 8610183 [details] [diff] [review]
Make URLValue::mString a smart pointer

Review of attachment 8610183 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/nsCSSValue.cpp
@@ +2340,4 @@
>  }
>  
>  css::URLValue::~URLValue()
> +{}

May as well remove the definition and put it inline in nsCSSValue.h.
Attachment #8610183 - Flags: review?(cam) → review+
Move URLValue::~URLValue inline into the header
Attachment #8610183 - Attachment is obsolete: true
Assignee: nobody → michael
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/eff5410a0db3
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.