1168167 - Mark LazyIdleThread::mIdleObserver with MOZ_UNSAFE_REF

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=97d050105ff2

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Mark LazyIdleThread::mIdleObserver with MOZ_UNSAFE_REF

Comment 2

[Benjamin Smedberg]

Comment on attachment 8610196 [details] [diff] [review]
Mark LazyIdleThread::mIdleObserver with MOZ_UNSAFE_REF

I can't figure out from the docs what MOZ_UNSAFE_REF does, so I don't think I can review this.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8610196 [details] [diff] [review]
Mark LazyIdleThread::mIdleObserver with MOZ_UNSAFE_REF

Review of attachment 8610196 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the change below.

::: xpcom/threads/LazyIdleThread.h
@@ +161,5 @@
>    /**
>     * Idle observer. Called when the thread is about to be shut down. Released
>     * only when Shutdown() is called.
>     */
> +  nsIObserver* MOZ_UNSAFE_REF("Caller must null if ptr becomes invalid") mIdleObserver;

I think the better annotation here is something like:

MOZ_UNSAFE_REF("See the documentation for SetWeakIdleObserver for lifetime information of this field")

as there's no referent for "Caller" here.

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Mark LazyIdleThread::mIdleObserver with MOZ_UNSAFE_REF

Update the commit message

Comment 5

[Nathan Froyd [:froydnj]]

Or:

MOZ_UNSAFE_REF("See the documentation for SetWeakIdleObserver for how the owner of LazyIdleThread should manage the lifetime information of this field")

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Yeah - I think I like that one better. I'll update it again.

Comment 7

[Nika Layzell [:nika] (ni? for response)]

Attachment: Mark LazyIdleThread::mIdleObserver with MOZ_UNSAFE_REF

Updated message again

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/871ac213933e

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/871ac213933e