View Page / Selection Source view port size should not be restricted by the popup window size

VERIFIED FIXED in Firefox 41

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: alice0775, Assigned: jryans)

Tracking

({regression, uiwanted, ux-visual-hierarchy})

41 Branch
mozilla41
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox41+ verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

[Tracking Requested - why for this release]:

1. Open attached
2. Click a link to open popup sindow
3. Perform "View Page Source" / "View selection Source" on the popup

Actual Results:
too small for source view

Expected results:
Size of source view should not be restricted by the popup window size
I think a reasonable approach here would be to attempt opening the view source tab in the same window as the popup's parent, instead of the window of the popup itself.
Summary: "View Page Source" & "View selection Source" view port size should not be restricted by the popup window size → View Page / Selection Source view port size should not be restricted by the popup window size
Assignee: nobody → jryans
Status: NEW → ASSIGNED
My patch here will depend on the patch in bug 1168095.
Depends on: 1168095
/r/9393 - Bug 1168198 - Avoid popups for view source tabs. r=mconley

Pull down this commit:

hg pull -r 47237a8f9086f8c6f3dae86a77dfb7d22fb7bc5d https://reviewboard-hg.mozilla.org/gecko/
Comment on attachment 8610863 [details]
MozReview Request: bz://1168198/jryans

/r/9393 - Bug 1168198 - Avoid popups for view source tabs. r=mconley

Pull down this commit:

hg pull -r 47237a8f9086f8c6f3dae86a77dfb7d22fb7bc5d https://reviewboard-hg.mozilla.org/gecko/
Attachment #8610863 - Flags: review?(mconley)
Bug 1168198 - Avoid popups for view source tabs. r=Gijs
Attachment #8611627 - Flags: review?(gijskruitbosch+bugs)
Attachment #8610863 - Flags: review?(mconley)
Alice0775, what do you think of the behavior now on Windows?  It seems good in my testing now on Windows since it moves to a non-popup window, but I wondered if you had any feedback.

Here's a testing build from try:

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jryans@gmail.com-895873102f83/try-win64/
Flags: needinfo?(alice0775)
the try server wfm.
Flags: needinfo?(alice0775)
Comment on attachment 8611627 [details]
MozReview Request: Bug 1168198 - Avoid popups for view source tabs. r=Gijs

https://reviewboard.mozilla.org/r/9393/#review8307

Ship It!
Attachment #8611627 - Flags: review?(gijskruitbosch+bugs) → review+
Blocks: 1168196
https://hg.mozilla.org/mozilla-central/rev/524ba07b73eb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Attachment #8610863 - Attachment is obsolete: true
Adding a tracking flag for FF41 to ensure we verify the fix before Firefox41 goes out. Setting the qe-verify flag to +.
Flags: qe-verify+
I was able to reproduce this issue on Firefox 41.0a1 (2015-05-25) using Windows 7 64-bit.

Verified fixed on Firefox 41.0a2 (2015-07-30) under Windows 7 64-bit, Ubuntu 13.10 64-bit and Mac OS X 10.10.4.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.