1168198 - View Page / Selection Source view port size should not be restricted by the popup window size

Status: VERIFIED FIXED

(Toolkit :: View Source, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]:

1. Open attached
2. Click a link to open popup sindow
3. Perform "View Page Source" / "View selection Source" on the popup

Actual Results:
too small for source view

Expected results:
Size of source view should not be restricted by the popup window size

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I think a reasonable approach here would be to attempt opening the view source tab in the same window as the popup's parent, instead of the window of the popup itself.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

My patch here will depend on the patch in bug 1168095.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=895873102f83

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: bz://1168198/jryans

/r/9393 - Bug 1168198 - Avoid popups for view source tabs. r=mconley

Pull down this commit:

hg pull -r 47237a8f9086f8c6f3dae86a77dfb7d22fb7bc5d https://reviewboard-hg.mozilla.org/gecko/

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8610863 [details]
MozReview Request: bz://1168198/jryans

/r/9393 - Bug 1168198 - Avoid popups for view source tabs. r=mconley

Pull down this commit:

hg pull -r 47237a8f9086f8c6f3dae86a77dfb7d22fb7bc5d https://reviewboard-hg.mozilla.org/gecko/

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1168198 - Avoid popups for view source tabs. r=Gijs

Bug 1168198 - Avoid popups for view source tabs. r=Gijs

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Alice0775, what do you think of the behavior now on Windows?  It seems good in my testing now on Windows since it moves to a non-popup window, but I wondered if you had any feedback.

Here's a testing build from try:

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-895873102f83/try-win64/

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Here's a 32 bit build as well:

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-895873102f83/try-win32/

Comment 9

[Alice0775 White]

the try server wfm.

Comment 10

[:Gijs (he/him)]

Comment on attachment 8611627 [details]
MozReview Request: Bug 1168198 - Avoid popups for view source tabs. r=Gijs

https://reviewboard.mozilla.org/r/9393/#review8307

Ship It!

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/524ba07b73eb

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/524ba07b73eb

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Adding a tracking flag for FF41 to ensure we verify the fix before Firefox41 goes out. Setting the qe-verify flag to +.

Comment 15

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 41.0a1 (2015-05-25) using Windows 7 64-bit.

Verified fixed on Firefox 41.0a2 (2015-07-30) under Windows 7 64-bit, Ubuntu 13.10 64-bit and Mac OS X 10.10.4.