1168243 - [e10s] View Selection Source does not work for Frame document

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Alice0775 White]

+++ This bug was initially created as a clone of Bug #1168089 +++

Steps To reproduce:
1. Open web page which is using frameset
2. Select text
3. Right click on the page
4. Choose "View Selection Source"

Actual Results:
Blank tab open but no contents

Expected Results:
Source code which is selected should be shown

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey Alice0775 - this bug is marked as affecting Fx 40. Are you certain this is the case? View Source in a tab should not be available in 40.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Mike Conley (:mconley) - Needinfo me! from comment #1)
> Hey Alice0775 - this bug is marked as affecting Fx 40. Are you certain this
> is the case? View Source in a tab should not be available in 40.

I can confirm that 40 is affected.  Both window and tab mode are affected, including 40's window mode before bug 1067325.  So, this is not a regression of the view source in tab work.

STR for 40:

1. Go to http://www.htmq.com/html/sample/frame.htm
2. Select text inside one of the frames
3. Right click -> View Selection Source

ER:

Should see source for the selected text

AR:

Empty window

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The core issue appears to be that viewPartialSource calls |focusedWindow.getSelection();|.

In e10s for a nested frame, this does return a Selection object, but it's an object for an empty selection.  So, something needs to be adjusted to get the proper Selection object for nested frames in e10s.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hey Alice0775 - do you think you'd be able to help me to find a regression window?

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Mike Conley (:mconley) - Needinfo me! from comment #4)
> Hey Alice0775 - do you think you'd be able to help me to find a regression
> window?

Is it the blocking bug Alice0775 noted (bug 917681), or is that just related to the issue?

Comment 6

[Alice0775 White]

Until landing of Bug 917681, No "View Selection Source" in contextmenu.
After landing of Bug 917681, "View Selection Source" in contextmenu, but a blank window/tab is produced.

Comment 7

[Alice0775 White]

Not regression, this is e10s implementation bug.

Comment 8

[Neil Deakin]

This should have been fixed by 1134585.

Comment 9

[Alice0775 White]

Verified to fix.

https://hg.mozilla.org/mozilla-central/rev/8cba870a352c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0 ID:20150811030206