Remove seemingly nonsensical code from nsDisplayTransform::GetDeltaToTransformOrigin

RESOLVED FIXED in Firefox 41

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8610305 [details] [diff] [review]
patch

Removing this code doesn't cause anything to fail on Try.

Note that this section of code used to be unconditional before bug 923193, part 1, but I realized in that bug that nsDisplayTransform::GetFrameBoundsForTransform (now TransformReferenceBox::EnsureDimensionsAreCached) always returns a rect with zero offset. Therefore this bit of code could/can only have an effect if aBoundsOverride is non-null.

I can't actually see a way in which aBoundsOverride can end up with non-zero offset either though. For example, when nsDisplayTransform::TransformRect passes in an override bounds it sets the offset of the 'newBounds' object that is passes to {0,0}.

Perhaps this code is in some way related to UNIFIED_CONTINUATIONS, but the UNIFIED_CONTINUATIONS code has never worked. Rather than have this mysterious bit of code left here I think we should remove (it unless someone can explain it). If something break as a result of removing it, we can add it back with a nice explanatory comment this time!
Attachment #8610305 - Flags: review?(matt.woodrow)
Comment on attachment 8610305 [details] [diff] [review]
patch

Review of attachment 8610305 [details] [diff] [review]:
-----------------------------------------------------------------

Let's give it a shot!
Attachment #8610305 - Flags: review?(matt.woodrow) → review+
(Assignee)

Updated

3 years ago
Summary: Remove broken code from nsDisplayTransform::GetDeltaToTransformOrigin → Remove seemingly nonsensical code from nsDisplayTransform::GetDeltaToTransformOrigin
https://hg.mozilla.org/mozilla-central/rev/3c9ee60d1ca5
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.