Closed
Bug 1168252
Opened 11 years ago
Closed 11 years ago
Support prompt dialog in smart-modal-dialog
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chens, Assigned: chens)
References
Details
Attachments
(2 files)
We should able to put DOM element as an additional option into smart-modal-dialog to support prompt dialog.
|
Assignee | |
Comment 1•11 years ago
|
||
John, would you review this patch? thanks!
Attachment #8611146 -
Flags: review?(im)
|
||
Updated•11 years ago
|
Assignee: nobody → chens
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8611146 [details] [review]
pull request to smart-modal-dialog
looks good to me.
Attachment #8611146 -
Flags: review?(im) → review+
|
||
Comment 3•11 years ago
|
||
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8612206 [details] [review]
[gaia] shamenchens:Bug1168252-SmartModalDialogForPrompt > mozilla-b2g:master
John, would you review this patch? thanks!
Attachment #8612206 -
Flags: review?(im)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8612206 [details] [review]
[gaia] shamenchens:Bug1168252-SmartModalDialogForPrompt > mozilla-b2g:master
As per offline discussion, this version is fine. But we should file a few bugs to fix regressions and issues:
1. we should set focus while modal-dialog-will-open event fired.
2. we should use normal text box to have correct font size
3. we should make clear button selectable and clickable.
The first one should be fixed asap.
Attachment #8612206 -
Flags: review?(im) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•