Closed
Bug 1168265
Opened 9 years ago
Closed 9 years ago
Clean up profiler's ChunkedJSONWriteFunc
Categories
(Core :: Gecko Profiler, defect)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: shu, Unassigned)
Details
Attachments
(1 file)
|
6.46 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
|
Reporter | |
Comment 1•9 years ago
|
||
One of the invariants you listed, mChunkEnd == mChunkList.back() + mChunkLengths.back() is not true. mChunkEnd *is* how capacity is tracked, and the chunk lengths are the actual lengths, so the best we can assert is >=.
Attachment #8610952 -
Flags: review?(mstange)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8610952 [details] [diff] [review] Clean up ChunkedJSONWriteFunc. Great, thanks!
Attachment #8610952 -
Flags: review?(mstange) → review+
https://hg.mozilla.org/mozilla-central/rev/4e6c2d88d5f9
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•