Closed
Bug 1168294
Opened 9 years ago
Closed 9 years ago
Useless check in DirCursor.java
Categories
(Testing Graveyard :: SUTAgent, defect)
Testing Graveyard
SUTAgent
Tracking
(firefox43 fixed)
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: alex.buck10, Mentored)
Details
(Keywords: coverity, Whiteboard: [good first bug][lang=C++][CID 80944][CID 81053])
Attachments
(1 file, 1 obsolete file)
1.88 KB,
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
https://dxr.mozilla.org/mozilla-central/source/build/mobile/sutagent/android/fencp/DirCursor.java#51 https://dxr.mozilla.org/mozilla-central/source/build/mobile/sutagent/android/ffxcp/DirCursor.java#51 This check is useless: if (vals == null) return; as vals is never null
Hi Sylvestre, I'd like to take this as my first bug please. Would you assign me?
Attachment #8614274 -
Flags: review?(sledru)
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8614274 [details] [diff] [review] remove redundant null checks You are doing two changes at the same time: the removal of the change & removal of trailing white spaces. Please focus on only a single change. (if you want to fix it, you can attach a separate patch)
Attachment #8614274 -
Flags: review?(sledru) → review-
Attachment #8614274 -
Attachment is obsolete: true
Attachment #8615506 -
Flags: review?(sledru)
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8615506 [details] [diff] [review] remove redundant null checks Much better. Now, you should find the official reviewer (I am not the owner of this code). You should look at the hg history of these files to find who is usually reviewing that.
Attachment #8615506 -
Flags: review?(sledru)
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → alex.buck10
Attachment #8615506 -
Flags: review?(cmtalbert)
Comment 6•9 years ago
|
||
Seems that "cmtalbert" is not a correct reviewer. And this bug is stuck in this state for more that two month.
Flags: needinfo?(alex.buck10)
Updated•9 years ago
|
Flags: needinfo?(sledru)
Comment 8•9 years ago
|
||
After two month, no body checked the patch. Because the review flag set to a wrong person. You're the mentor of this bug, and I though you should guide the contributer to get its patch reviewed. That's why I flagged you in `needinfo' field. Sorry if I did something wrong.
Reporter | ||
Comment 9•9 years ago
|
||
Right, sorry about that. Michael, do you know who could review this patch? Thanks
Flags: needinfo?(michael.l.comella)
Comment on attachment 8615506 [details] [diff] [review] remove redundant null checks Review of attachment 8615506 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me – thanks Alex! Sorry for the delay. I made a push to our try test servers (above). Once the push goes green, you can add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results. [1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
Attachment #8615506 -
Flags: review?(cmtalbert) → review+
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(alex.buck10)
Keywords: checkin-needed
Assignee | ||
Comment 11•9 years ago
|
||
Thank you for the help Michael/Sylvestre. I checked the build in treeherder and it's green so have added the checkin-needed keyword.
Comment 12•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba314309da74
Keywords: checkin-needed
Comment 13•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ba314309da74
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Updated•6 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•