Closed
Bug 1168297
Opened 10 years ago
Closed 10 years ago
Make SpatialNavigator more configurable
Categories
(Firefox OS Graveyard :: Gaia::TV, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: lchang, Assigned: lchang)
Details
(Whiteboard: [partner-interest])
Attachments
(1 file)
I intend to add following options to SpatialNavigator module.
- overlayThreshold: adjust the threshold of how an element is considered in the cross directions.
- ignoreHiddenElement: don't traverse into hidden elements so we may avoid removing and re-adding elements frequently in some case.
- rememberSource: When calling `move`, SpatialNavigator tends to move the focus back to the previous element if any possible.
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8610522 [details] [review]
[gaia] luke-chang:1168297_spatial_navigator_configurable > mozilla-b2g:master
Hi Rex,
Could you please help take a look? Thanks.
Attachment #8610522 -
Flags: review?(rexboy)
Comment 3•10 years ago
|
||
Comment on attachment 8610522 [details] [review]
[gaia] luke-chang:1168297_spatial_navigator_configurable > mozilla-b2g:master
Looks good to me but we need to update comments. See Github for details.
Thank you!
Attachment #8610522 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Rex, Thanks for reviewing.
test passed: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=dfd6d67f58218e740de8af883c4b7077399097e4
landed on master: https://github.com/mozilla-b2g/gaia/commit/58768819a8d3f7b2e878ae0f1cb9484441be92cc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Whiteboard: [partner-interest]
You need to log in
before you can comment on or make changes to this bug.
Description
•