Closed Bug 1168304 Opened 9 years ago Closed 9 years ago

KeyLayout parser treats 'led' keyword as error

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

Product:
Firefox OS Graveyard
Component:
GonkIntegration
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1168730

People

(Reporter: pelloux, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150521030204

Steps to reproduce:

KeyLayoutMap parser (gecko/widget/gonk/libui/KeyLayoutMap.cpp) only knows 2 keywords: 'key' and 'axis'. But 'led' is a valid one as well, e.g in 'Generic.kl':

led 0x00 NUM_LOCK


Actual results:

Generic.kl layout is incorrectly rejected


Expected results:

Generic.kl layout should be used when no device specific layout has been foun.
That might also be what I am hitting on Xperia M2 and why I dont' have VolUp working on that device.

Pierre-Éric landed a workaround on his device tree: https://github.com/Phoxygen/device-shamu/commit/3e37ec219dea4cbaed17aea377858fcc8876bfb4
Flags: needinfo?(lissyx+mozillians)
Flags: needinfo?(adam)
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(lissyx+mozillians)
Flags: needinfo?(adam)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.