Improve version handling in bluetoothd

RESOLVED FIXED in Firefox OS master

Status

Firefox OS
Bluetooth
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

unspecified
2.2 S13 (29may)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-master fixed)

Details

Attachments

(1 attachment)

We should push version handling in bluetoothd into the makefile to make the source code easier to read.

We should also add documentation for porting and versioning.
Created attachment 8610523 [details] [review]
Github pull request

Some improvements to version handling before we land GATT support.
Attachment #8610523 - Flags: review?(shuang)
I have a question for 'Bug 1168344: Remove version protections in AVRCP module' and one suggestion for 'Bug 1168344: Handle Android versions in makefile'.
Attachment #8610523 - Flags: review?(shuang) → review+
(In reply to Shawn Huang [:shawnjohnjr] from comment #2)
> I have a question for 'Bug 1168344: Remove version protections in AVRCP
> module' and one suggestion for 'Bug 1168344: Handle Android versions in
> makefile'.

Thanks Shawn. I put the answers into the Github pull request.

Since it's r+'ed, I'll update the pull request and land the changes later today. Ping me to interfere.
Comment on attachment 8610523 [details] [review]
Github pull request

Updated Github pull request

  - call CLEAR_VARS near the top of the makefile
  - fixed makefile error string
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/platform_system_bluetoothd/commit/4132c66e4bc78e119eb1cf34b6cf77db8e714e9a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-b2g-master: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S13 (29may)
You need to log in before you can comment on or make changes to this bug.