Closed
Bug 1168344
Opened 10 years ago
Closed 10 years ago
Improve version handling in bluetoothd
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
2.2 S13 (29may)
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(1 file)
We should push version handling in bluetoothd into the makefile to make the source code easier to read.
We should also add documentation for porting and versioning.
| Assignee | ||
Comment 1•10 years ago
|
||
Some improvements to version handling before we land GATT support.
Attachment #8610523 -
Flags: review?(shuang)
I have a question for 'Bug 1168344: Remove version protections in AVRCP module' and one suggestion for 'Bug 1168344: Handle Android versions in makefile'.
Attachment #8610523 -
Flags: review?(shuang) → review+
| Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Shawn Huang [:shawnjohnjr] from comment #2)
> I have a question for 'Bug 1168344: Remove version protections in AVRCP
> module' and one suggestion for 'Bug 1168344: Handle Android versions in
> makefile'.
Thanks Shawn. I put the answers into the Github pull request.
Since it's r+'ed, I'll update the pull request and land the changes later today. Ping me to interfere.
| Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8610523 [details] [review]
Github pull request
Updated Github pull request
- call CLEAR_VARS near the top of the makefile
- fixed makefile error string
| Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-master:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S13 (29may)
You need to log in
before you can comment on or make changes to this bug.
Description
•