1168446 - Cleanup interface of |BluetoothSocket|

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

With the changes from bug 1161020, we can clean up the interface of |BluetoothSocket| to be more like the interfaces in ipc/unixsocket. Some methods can also be removed.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1168446: Remove |Disconnect| from BlueZ's |BluetoothSocket|

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1168446: Remove |BluetoothSocket::GetSocketAddr|

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1168446: Change |BluetoothSocket::{ListenSocket,ConnectSocket}| interface

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [04] Bug 1168446: Don't store connection parameters in |BluetoothSocket|

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e0efdc09998

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

There was a problem with the build infrastructure. Trying again

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0c65af943db

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8611109 [details] [diff] [review]
[04] Bug 1168446: Don't store connection parameters in |BluetoothSocket|

Review of attachment 8611109 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good to me for setting auth/encrypt parameters in connect/listen.

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks Shawn!

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=37c9f1961a9d

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/543d15b14575
https://hg.mozilla.org/integration/b2g-inbound/rev/fdbfea9d6c0c
https://hg.mozilla.org/integration/b2g-inbound/rev/b8289e7701c9

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/543d15b14575
https://hg.mozilla.org/mozilla-central/rev/fdbfea9d6c0c
https://hg.mozilla.org/mozilla-central/rev/b8289e7701c9
https://hg.mozilla.org/mozilla-central/rev/37c9f1961a9d