1168478 - Combine border & padding args in nsIFrame::ComputeSize API

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Quoting bug 1166728 comment 14, on nsFrame::ComputeSize():

> [...] I think a lot of functions like this pass border &
> padding separately *so that we can support* box-sizing: padding-box vs.
> border-box.  Now that border/padding will always be added/subtracted as a
> package, we might want to consider combining these args into aBorderPadding
> in a lot of spots, so that we don't need to perform "aBorder + aPadding" all
> over the place.

nsIFrame::ComputeSize (and its various implementations in each frame class) is one place where this can probably happen.

nsLayoutUtils::ComputeSizeWithIntrinsicDimensions would then need to change as well (since it's used by various nsIFrame::ComputeSize implementations).

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1168478 Part 1 - Combine the border and padding argument for nsIFrame::ComputeAutoSize().

Also, revise the ComputeAutoSize()'s documentation.

This change shouldn't change behavior.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1168478 Part 2 - Combine the border and padding arguments for nsIFrame::ComputeSize().

Also combine the border and padding arguments for
nsContainerFrame::ComputeSizeWithIntrinsicDimensions(), too. This methods is
used as a helper to implement ComputeSize() for replaced element. That is, its
callers are all within frame classes' ComputeSize()'s overridden methods, so I'm
not convert them in a separate patch.

This change shouldn't change behavior.

Depends on D90063

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/918080b4e7ae
Part 1 - Combine the border and padding argument for nsIFrame::ComputeAutoSize(). r=dholbert
https://hg.mozilla.org/integration/autoland/rev/977b599edf3f
Part 2 - Combine the border and padding arguments for nsIFrame::ComputeSize(). r=dholbert

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/918080b4e7ae
https://hg.mozilla.org/mozilla-central/rev/977b599edf3f