Open Bug 1168478 Opened 5 years ago

Combine border & padding args in nsIFrame::ComputeSize API

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

Tracking Status
firefox41 --- affected

People

(Reporter: dholbert, Unassigned)

References

Details

Quoting bug 1166728 comment 14, on nsFrame::ComputeSize():

> [...] I think a lot of functions like this pass border &
> padding separately *so that we can support* box-sizing: padding-box vs.
> border-box.  Now that border/padding will always be added/subtracted as a
> package, we might want to consider combining these args into aBorderPadding
> in a lot of spots, so that we don't need to perform "aBorder + aPadding" all
> over the place.

nsIFrame::ComputeSize (and its various implementations in each frame class) is one place where this can probably happen.

nsLayoutUtils::ComputeSizeWithIntrinsicDimensions would then need to change as well (since it's used by various nsIFrame::ComputeSize implementations).
You need to log in before you can comment on or make changes to this bug.