Closed
Bug 1168535
Opened 9 years ago
Closed 9 years ago
Fix upload_symbols.py's retry logic and log more information when upload_symbols.py gets an error from the symbol upload API
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox39 fixed, firefox40 fixed, firefox41 fixed, firefox-esr31 fixed, firefox-esr38 fixed, b2g-v2.0 fixed, b2g-v2.0M fixed, b2g-v2.1 fixed, b2g-v2.1S fixed, b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
mozilla41
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(2 files, 1 obsolete file)
Currently when upload_symbols.py gets an error from the symbol upload API it just prints the error status like: 04:52:23 INFO - Error: got HTTP response 400 This is not super helpful. It should dump the full response headers + body for diagnostics.
Assignee | ||
Comment 1•9 years ago
|
||
/r/9465 - bug 1168535 - print error response body in upload_symbols.py. r?gps Pull down this commit: hg pull -r 3d70a156280c91e4934ec0da60f2d8db2638064c https://reviewboard-hg.mozilla.org/gecko/
Attachment #8611322 -
Flags: review?(gps)
Assignee | ||
Comment 2•9 years ago
|
||
I tested this locally by switching the upload URL to point at a local python httpd that served error codes. Running `./mach build uploadsymbols` it looks like: ``` 0:01.23 Error: got HTTP response 500: Error 0:01.23 Response body: 0:01.23 ==================== 0:01.23 <head> 0:01.23 <title>Error response</title> 0:01.23 </head> 0:01.23 <body> 0:01.23 <h1>Error response</h1> 0:01.23 <p>Error code 500. 0:01.23 <p>Message: Error. 0:01.23 <p>Error code explanation: 500 = Server got itself in trouble. 0:01.23 </body> 0:01.23 0:01.23 ==================== 0:01.23 0:01.25 make: *** [uploadsymbols] Error 1 ``` Also I stuck a -u in the Python invocation to unbuffer the output, since the errors were going to stderr and thus the log looked weird because it would print the error and *then* the "Retrying".
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8611322 [details] MozReview Request: bz://1168535/ted /r/9465 - bug 1168535 - print error response body in upload_symbols.py. r?gps /r/9467 - bug 1168535 - re-open the zip file for each upload_symbols retry. r?gps Pull down these commits: hg pull -r 1f01910a42fd33cfb5d316f17c44fc940475134d https://reviewboard-hg.mozilla.org/gecko/
Assignee | ||
Comment 4•9 years ago
|
||
While I was writing that patch I figured out bug 1168368 so I wrote the patch to fix that too, but that bug is marked moco-confidential so I put the patch here. Apparently I didn't fix bug 1165347 properly the first time.
Blocks: 1165347
Comment 5•9 years ago
|
||
https://reviewboard.mozilla.org/r/9465/#review8247 Ship It!
Comment 6•9 years ago
|
||
https://reviewboard.mozilla.org/r/9467/#review8249 Ship It!
Comment 7•9 years ago
|
||
Comment on attachment 8611322 [details] MozReview Request: bz://1168535/ted https://reviewboard.mozilla.org/r/9463/#review8251 Ship It!
Attachment #8611322 -
Flags: review?(gps) → review+
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/accf471c90ce https://hg.mozilla.org/integration/mozilla-inbound/rev/87c37eb7ba36
Assignee | ||
Updated•9 years ago
|
Summary: Log more information when upload_symbols.py gets an error from the symbol upload API → Fix upload_symbols.py's retry logic and log more information when upload_symbols.py gets an error from the symbol upload API
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/accf471c90ce https://hg.mozilla.org/mozilla-central/rev/87c37eb7ba36
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment 10•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/61093ea985b6 https://hg.mozilla.org/releases/mozilla-aurora/rev/9c9b478fcb51
status-firefox40:
--- → fixed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/8b8bd757099b https://hg.mozilla.org/releases/mozilla-beta/rev/1f0092bc321a
status-firefox39:
--- → fixed
Flags: in-testsuite-
Comment 12•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-esr38/rev/9792a6e67d71 https://hg.mozilla.org/releases/mozilla-esr38/rev/939217f036c3
status-firefox-esr38:
--- → fixed
Comment 13•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/19e28150c7d4 https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c163c2a5b921
status-b2g-v2.2:
--- → fixed
Comment 14•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f8fb3b92c926 https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/cc44020c62f8
status-b2g-v2.1:
--- → fixed
Comment 15•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/560826c15c8e https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/f1380f2c8d80
status-b2g-v2.0:
--- → fixed
Comment 16•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-esr31/rev/882d5e18eef4 https://hg.mozilla.org/releases/mozilla-esr31/rev/a31be6d7406f
status-firefox-esr31:
--- → fixed
Comment 17•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/f8fb3b92c926 https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/cc44020c62f8
Comment 18•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/560826c15c8e https://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/f1380f2c8d80
status-b2g-v2.0M:
--- → fixed
Updated•9 years ago
|
status-b2g-v2.1S:
--- → fixed
status-b2g-master:
--- → fixed
Assignee | ||
Comment 19•9 years ago
|
||
Attachment #8611322 -
Attachment is obsolete: true
Attachment #8620362 -
Flags: review+
Attachment #8620363 -
Flags: review+
Assignee | ||
Comment 20•9 years ago
|
||
Assignee | ||
Comment 21•9 years ago
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•