Add default preference to disable reader view intro

RESOLVED FIXED in Firefox 38

Status

Testing
Firefox UI Tests
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: galgeek, Assigned: galgeek)

Tracking

unspecified
mozilla41
Points:
---

Firefox Tracking Flags

(firefox38 fixed, firefox38.0.5 fixed, firefox39 fixed, firefox40 fixed, firefox41 fixed, firefox-esr38 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The new Pocket button intro interferes with some tests. It should be disabled by default, by setting browser.toolbarbuttons.introduced.pocket-button to true.
(Assignee)

Comment 1

2 years ago
(In reply to Barbara Miller (:galgeek) from comment #0)

It looks like it's not Pocket but rather the Reading List/Reader View intro that we ought to disable.
Summary: Add default preference to disable pocket button intro → Add default preference to disable reader view intro
(Assignee)

Comment 2

2 years ago
Created attachment 8610808 [details] [review]
github pull request
Attachment #8610808 - Flags: feedback?(hskupin)
https://github.com/mozilla/firefox-ui-tests/commit/594b6105b3198042288efd3e1a2c32cc7d609ae9 (master)

We will have to backport this commit down to beta, which will soon be merged into release.
Assignee: nobody → galgeek
status-firefox38: --- → unaffected
status-firefox38.0.5: --- → affected
status-firefox39: --- → affected
status-firefox40: --- → affected
status-firefox41: --- → fixed
Target Milestone: --- → Firefox 41
Blocks: 1165215
https://github.com/mozilla/firefox-ui-tests/commit/ba0dcf082a5d02f3e718550b8876d7f4052e5f1e (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/bcd897d1b7903c9df6071aef7347bbb50db22618 (beta)

mozilla-release and mozilla-esr38 branches got rebased against beta, so they have the same changeset.
status-firefox38: unaffected → fixed
status-firefox38.0.5: affected → fixed
status-firefox39: affected → fixed
status-firefox40: affected → fixed
status-firefox-esr38: --- → fixed
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Comment on attachment 8610808 [details] [review]
github pull request

Missed to set the r+ flag when I reviewed the patch.
Attachment #8610808 - Flags: feedback?(hskupin) → review+
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.