Closed Bug 1168564 Opened 4 years ago Closed 4 years ago

Fix some RTL issues in the Loop panel and conversation window

Categories

(Hello (Loop) :: Client, defect, P4)

defect
Points:
1

Tracking

(firefox39 wontfix, firefox40 fixed, firefox41 fixed)

RESOLVED FIXED
mozilla41
Iteration:
41.2 - Jun 8
Tracking Status
firefox39 --- wontfix
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

There's a few issues in the Loop panel and conversation window that are currently fairly obvious when you're using rtl locales.

Namely:

- If there's someone in a room, the blue dot touches the room name
- Copy button touches the room name
- The context information icon is too far indented
- The contact avatar, gmail icon and text are too close and in the case of the icon is on top of the avatar
- The menu for a contact is displayed in the wrong location & has its icons adjacent to the text with no margin
- In the conversation window, the context icon is displayed on the left hand side underneath the 'x' and edit buttons, rather than on the right hand side.
-
Mike: Please especially check the conversation window changes for context - this seems to be backing out something you specificially put in, so I'm slightly concerned I'm missing something.

Otherwise, this is what comes from having your dev environment set up for rtl for too long ;-) On the other hand, its taught me a lot about what to look out for when reviewing/writing css and considering RTL locales.
Attachment #8610791 - Flags: review?(mdeboer)
Comment on attachment 8610791 [details] [diff] [review]
Fix some general RTL issues in the Loop panel and conversation window.

Review of attachment 8610791 [details] [diff] [review]:
-----------------------------------------------------------------

Looks very good! It seems like the flexbox model takes care of RTL behavior for us, which is surprising, but cool.

Can you file a follow-up that re-orders the buttons in the conversation toolbar in RTL mode? Or do it here, but in that case I'd like to re-review your patch ;-)
Attachment #8610791 - Flags: review?(mdeboer) → review+
(In reply to Mike de Boer [:mikedeboer] from comment #2)
> Can you file a follow-up that re-orders the buttons in the conversation
> toolbar in RTL mode? Or do it here, but in that case I'd like to re-review
> your patch ;-)

Filed as bug 1168766 and set it up to be mentored.
https://hg.mozilla.org/mozilla-central/rev/d07aaab9e7f5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment on attachment 8610791 [details] [diff] [review]
Fix some general RTL issues in the Loop panel and conversation window.

Approval Request Comment
[Feature/regressing bug #]: General Firefox Hello, and some of it is context in conversations
[User impact if declined]: Bad layout and positioning in RTL locales
[Describe test coverage new/current, TreeHerder]: Landed in m-c, css only.
[Risks and why]: Low, css localised to Hello.
[String/UUID change made/needed]: None

Although some of this affects beta, not requesting uplift to there as this would need more work to extract parts of various previous patches to get everything working right. Moving this forward to aurora seems like a reasonable balance.
Attachment #8610791 - Flags: approval-mozilla-aurora?
Attachment #8610791 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.