Incorrect color for the day-off part of the selected day in week view

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Calendar Views
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Decathlon, Assigned: Decathlon)

Tracking

Lightning 4.0.0.1
4.0.0.1

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
The day-off part of the selected day, in week view, currently has the color of the "today" day instead of a specific color.
(Assignee)

Comment 1

2 years ago
Created attachment 8610802 [details] [diff] [review]
patch - v1

The patch should fix.
Attachment #8610802 - Flags: review?(richard.marti)
Comment on attachment 8610802 [details] [diff] [review]
patch - v1

r+ with changing the [systemcolors] variable --viewDayBoxOffSelectedBackground: rgba(0, 0, 0, .1); to rgba(0, 0, 0, .2). Without this the selected offtime isn't good visible without this change.
Attachment #8610802 - Flags: review?(richard.marti) → review+
(Assignee)

Comment 3

2 years ago
Created attachment 8611387 [details] [diff] [review]
patch - v2

(In reply to Richard Marti (:Paenglab) from comment #2)

> r+ with changing the [systemcolors] variable
> --viewDayBoxOffSelectedBackground: rgba(0, 0, 0, .1); to rgba(0, 0, 0, .2).
> Without this the selected offtime isn't good visible without this change.

Thanks, I had forgotten the "systemcolors" part.
Attachment #8610802 - Attachment is obsolete: true
Attachment #8611387 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

2 years ago
Comment on attachment 8611387 [details] [diff] [review]
patch - v2

Review of attachment 8611387 [details] [diff] [review]:
-----------------------------------------------------------------

The bug is also in beta.
Attachment #8611387 - Flags: approval-calendar-beta?(philipp)
Attachment #8611387 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8611387 [details] [diff] [review]
patch - v2

Ok, please push soon, I'm not sure if there will be another beta build. When pushing to beta, please push to default and THUNDEBIRD_38_VEBRANCH.
Attachment #8611387 - Flags: approval-calendar-release+
Attachment #8611387 - Flags: approval-calendar-beta?(philipp)
Attachment #8611387 - Flags: approval-calendar-beta+
Attachment #8611387 - Flags: approval-calendar-aurora?(philipp)
Attachment #8611387 - Flags: approval-calendar-aurora+
(Assignee)

Comment 6

2 years ago
Pushed to
comm-central: http://hg.mozilla.org/comm-central/rev/00fc2020a1a1
comm-aurora:  http://hg.mozilla.org/releases/comm-aurora/rev/0c7925f2a61b
comm-release: http://hg.mozilla.org/releases/comm-release/rev/dca7454ed8b4
comm-beta:    http://hg.mozilla.org/releases/comm-beta/rev/b212707c7347
              http://hg.mozilla.org/releases/comm-beta/rev/53d77f754b37
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.1
Version: Trunk → Lightning 4.1

Comment 7

2 years ago
Is fixed for 4.0 too (THUNDEBIRD_38_VEBRANCH).
Keywords: checkin-needed
Version: Lightning 4.1 → Lightning 4.0
(Assignee)

Comment 8

2 years ago
OK, thanks.
So, also the target milestone should be 4.0, is it right?

Updated

2 years ago
Target Milestone: 4.1 → 4.0
You need to log in before you can comment on or make changes to this bug.