Closed Bug 1168590 Opened 9 years ago Closed 8 years ago

Unreachable code in QuotaClient::CheckIntegrity()

Categories

(Core :: Storage: IndexedDB, defect)

Product:
Core
Component:
Storage: IndexedDB
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1256593
Tracking Flags:
Tracking Status
firefox41 --- affected

People

(Reporter: mccr8, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1299625]) 

Coverity pointed this out.  changedForeignKeys always equals !foreignKeysWereEnabled, so in this code the second branch is always false:

    if (changedForeignKeys) {
      nsAutoCString stmtSQL;
      stmtSQL.AssignLiteral("PRAGMA foreign_keys = ");
      if (foreignKeysWereEnabled) {
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.