[infinite loop] bugs - nsNNTPProtocol.cpp

VERIFIED FIXED in M10

Status

MailNews Core
Networking
P3
normal
VERIFIED FIXED
19 years ago
10 years ago

People

(Reporter: jay, Assigned: Scott MacGregor)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

19 years ago
Analysis of the code has determined possible infinite loop
or problem in the code below.  See bug
http://bugzilla.mozilla.org/show_bug.cgi?id=11588
for more information

  nsNNTPProtocol.cpp:1048: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:1238: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:1318: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:1373: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:1435: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:1515: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:2670: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:2814: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:3100: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:3245: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:4467: warning: unsigned value < 0 is always 0
(Reporter)

Updated

19 years ago
Blocks: 11588

Comment 1

19 years ago
Here are some more locations that might have potential problems:

  nsNNTPProtocol.cpp:1048: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:1238: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:1318: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:1373: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:1435: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:1515: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:2670: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:2814: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:3100: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:3245: warning: unsigned value < 0 is always 0
  nsNNTPProtocol.cpp:4467: warning: unsigned value < 0 is always 0

Comment 2

19 years ago
Sorry, didn't realize they were the same line numbers...woops!
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
Target Milestone: M10

Updated

19 years ago
Component: Browser-General → Networking-Mail
Product: Browser → MailNews
QA Contact: leger → lchiang
(Assignee)

Updated

19 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

19 years ago
I've checked in the appropriate code changes for the lines listed in this bug
report. They turned out to all be harmless.

Updated

19 years ago
QA Contact: lchiang → ppandit

Comment 4

19 years ago
Par or Suresh? Can you verify?

Comment 5

19 years ago
Scott - can you point out what files you modified?
(Assignee)

Comment 6

19 years ago
Hey Par...i just modified the file listed above in this bug report:
news\src\nsNntpProtocol.cpp

Comment 7

19 years ago
par, can you verify this now?

Updated

19 years ago
Status: RESOLVED → VERIFIED

Comment 8

19 years ago
Based on checking
http://cvs-mirror.mozilla.org/webtools/bonsai/cvsview2.cgi?diff_mode=context&whi
tespace_mode=show&file=nsNNTPProtocol.cpp&root=/cvsroot&subdir=mozilla/mailnews/
news/src&command=DIFF_FRAMESET&rev1=1.96&rev2=1.97

everything looks good.

VERIFIED.
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.