Closed Bug 1168618 Opened 5 years ago Closed 5 years ago

Rename immediate to isImmediate in DynamicToolbar.setVisible

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: mcomella, Assigned: bandali, Mentored)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 file)

I find `immediate` to be unintuitive.

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug (I recommend using the "Need more information from" box at the bottom of the page so I get a notification - it's harder to lose track of), or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^
I would like to work on this issue.
Sure, Amin! You'll be assigned when you post a patch.
Assignee: nobody → me
Attachment #8612512 - Flags: review?(michael.l.comella)
Comment on attachment 8612512 [details] [diff] [review]
bug1168618_immediate-to-isimmediate.patch

Review of attachment 8612512 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great to me - thanks, Amin!

I made a push to our try test servers (see above).

Once it goes green, feel free to add the checkin-needed keyword [1]. Let me know if you need help reading the results. Note that all patches that use "checkin-needed" must also have an associated green try run.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
Attachment #8612512 - Flags: review?(michael.l.comella) → review+
Awesome, thanks for reviewing Michael!

I'll keep an eye on the build status and will add checkin-needed after/if it goes green.

Thanks again for helping me with my very first Firefox issue :)
Keywords: checkin-needed
Marking this as resolved (worksforme).
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
"Reopening" this. Sorry, this was a mistake on my part.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Status: REOPENED → NEW
https://hg.mozilla.org/mozilla-central/rev/f93fc9dbb942
Status: NEW → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.