Closed Bug 1168624 Opened 4 years ago Closed 4 years ago

Fix somewhat sub-optimal code introduced in bug 967494 (no functional change)

Categories

(Thunderbird :: Message Compose Window, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 41.0

People

(Reporter: jorgk, Assigned: jorgk)

Details

Attachments

(1 file)

As Neil pointed out in bug 1163395 comment #2, some of the code introduced into C-C in bug 967494 was a little on the clumsy side. We should fix this.

document.documentElement instead of document.getElementById("msgcomposeWindow"),
GetMsgSubjectElement() instead of document.getElementById('msgSubject'),
etc.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Comment on attachment 8611058 [details] [diff] [review]
Fixed the clumsy code

(Not a reviewer for /mail sorry)
Attachment #8611058 - Flags: review?(neil)
Attachment #8611058 - Flags: review?(mkmelin+mozilla)
Attachment #8611058 - Flags: feedback+
Neil: You said so before, but you're reviewing the very same stuff in SeaMonkey.
The original reviewer, who you've nominated again, didn't notice the clumsiness and let it slip through ;-(
Will carry fix over to bug 1168945, so we won't need two patches.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
Attachment #8611058 - Flags: review?(mkmelin+mozilla)
Fixed by bug 1168945.
Resolution: WONTFIX → FIXED
Target Milestone: --- → Thunderbird 41.0
You need to log in before you can comment on or make changes to this bug.