1168633 - [Aries][Dialer] Call log does not display a 'Dialer Send/Receive' icon in the background when no calls are present in log

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P3)

Description

[Oliver Nelson [:oliverthor]]

Attachment: aries_callog_missing_image.png

Description:
When the user is located in the call log of their Dialer app when no calls are present, they will observe that no background Dialer icon is present. 


PreReq:
* no calls in call log; delete calls if any
Repro Steps:
1) Update a Xperia Z3 Compact (B2G)
 to 20150526104521
2) Open the Dialer app
3) Tap far left icon for 'Call Log'
4) Observe UI with no calls

Actual:
No 'Dialer' icon when no calls present

Expected:
'Dialer' icon is in the background of text when no calls are present


Environmental Variables:
Device: Xperia Z3 Compact (B2G)
Build ID: 20150526104521
Gaia: 0359bf81f96a5356dacfc07e12ca72df61cbd638
Gecko: e537a1ba501b
Version: 41.0a1 (3.0)


Repro frequency: 5/5
See attached: 
screenshot

Comment 1

[Oliver Nelson [:oliverthor]]

Issue DOES NOT REPRODUCE on 3.0 for flame devices
Results: Call log has Dialer icon when no calls are present

Environmental Variables:
Device: Flame 3.0
BuildID: 20150526104742
Gaia: 0d67eb545b2f4342525d14e1a10e80c91c87ada0
Gecko: e537a1ba501b
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 41.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Comment 2

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Regression from the Flame.

Comment 3

[Doug Sherk (:drs) (inactive)]

[Blocking Requested - why for this release]:

Carol, could you provide a graphic for this at 2.25x resolution?

Comment 4

[Justin D'Arcangelo [:justindarc]]

The issue seems to be that the current 2.25x version of this image is white and doesn't show up against the white background. Compare this to the 1.5x version (used for Flame) where the image is light grey.

1.5x:
https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/style/images/ComLog_200x200_clock%401.5x.png

2.25x:
https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/style/images/ComLog_200x200_clock%402.25x.png

Comment 5

[Carol Huang [:Carol]]

Attachment: [e-mail]

Hi,
The attachment is the image for 2.25x.
Let me know if there's any other question.
Thanks!

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comms triage: Regression from the Flame.

Comment 7

[Pi Wei Cheng [:piwei] (inactive)]

Fixing tracking flag

Comment 8

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: Differences between the @2x and @2.25x versions

I was about to land the new asset but I've noticed that the arrows are slightly different in shape between the 2.0x and the 2.25x versions. I've attached a screenshot with the differences highlighted against a black background. Was this intended Carol or should it be fixed before we land the new image?

Comment 9

[Carol Huang [:Carol]]

Attachment: images_bug 1168633.zip

Hi Gabriele,
I've updated all 4 sizes of the images.
Could you replace the new one in attachment? Thanks!!

Let me know if there's any other question.

Comment 10

[Gabriele Svelto [:gsvelto] (PTO)]

Thanks Carol, unfortunately the zip file you attached is empty, maybe you attached the wrong one?

Comment 11

[Carol Huang [:Carol]]

Attachment: images_bug 1168633.zip

Sorry for the inconvenience! I've attached the zip again!
thanks!!

Comment 12

[Doug Sherk (:drs) (inactive)]

Attachment: Add call log background image at 2.25x resolution, update other images.

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] DouglasSherk:1168633-call-log-background > mozilla-b2g:master

Comment 14

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8664594 [details] [review]
[gaia] DouglasSherk:1168633-call-log-background > mozilla-b2g:master

LGTM with a nit, please apply PNG recompression before landing. From your gaia directory this should do the trick:

./tools/png_recompress.sh -v \
    apps/communications/dialer/style/images/ComLog_200x200_clock.png \
    apps/communications/dialer/style/images/[e-mail] \
    apps/communications/dialer/style/images/[e-mail] \
    apps/communications/dialer/style/images/[e-mail]

You will need the advancecomp/advpng and optipng tools installed for this to work.

Comment 15

[Doug Sherk (:drs) (inactive)]

Thanks, didn't know about that. 

https://github.com/mozilla-b2g/gaia/commit/8154e6cdfd44cc6107aa95f38316146504661bea

Comment 16

[Shally Li（leave from Mozilla）]

Hi Doug,

    This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0. It displays a 'Dialer Send/Receive' icon in the background as expected, but the part of 'Dialer Send/Receive' icon is shown at the upper of the line in the background on Flame KK v2.5, which is inconsistent with Aries KK v2.5. 
    Could you help to double check the actual results? 

Thank you very much.


--------------------------------------------------------------------------------------------
Actual results: On 'Call log' tab, it displays a 'Dialer Send/Receive' icon in the background when no calls are present in log. But the part of 'Dialer Send/Receive' icon is shown at the upper of the line in the background on Flame KK v2.5, which is inconsistent with Aries KK v2.5.

See attachment: verify_Flame&Aries_v2.5.png
Reproduce rate: 0/10


Device: Flame KK 2.5(Pass)
Build ID               20150927150205
Gaia Revision          285486b417f1cb8316b19c0698a6655fc053fbd6
Gaia Date              2015-09-25 14:11:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6256ec9113c115141aab089c45ee69438884b680
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150927.184956
Firmware Date          Sun Sep 27 18:50:08 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150927001555
Gaia Revision          285486b417f1cb8316b19c0698a6655fc053fbd6
Gaia Date              2015-09-25 14:11:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6256ec9113c115141aab089c45ee69438884b680
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150926.233607
Firmware Date          Sat Sep 26 23:36:15 UTC 2015
Bootloader             s1

Comment 17

[Shally Li（leave from Mozilla）]

Attachment: verify_Flame&Aires_v2.5.png