Closed
Bug 1168634
Opened 9 years ago
Closed 9 years ago
Enable chunk-by-runtime for Mochitest-devtools
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(firefox41 fixed)
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: jgriffin, Assigned: jgriffin)
References
Details
Attachments
(1 file)
3.92 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
I'm trying to increase the number of chunks of mochitest-devtools on linux32 debug since chunk 1 almost always times out. However, even doubling the number of chunks, this problem persists, and new chunks are quite short in duration. See https://treeherder.mozilla.org/#/jobs?repo=cedar&exclusion_profile=false. I'm guessing we need to land updates to the runtimes files for linux32 debug. Do we have an ActiveData query that can be used to do this?
Comment 1•9 years ago
|
||
We're normalizing the chunks already? My understanding is that this is straight run-by-dir chunking at the moment (i.e. we can't do anything about it unless we alter the directory structure of the tests).
Comment 2•9 years ago
|
||
bug 1142050 added the functionality to Mochitest but it's not enabled yet, AFAIK. I don't know if there's a separate bug tracking enabling it. If not, maybe this could be that bug.
Comment 3•9 years ago
|
||
Yeah, it's landed but not enabled. We were going to try and find a contributor to turn it on, but that hasn't happened yet. This seems like a good bug to enable it. I started writing a script that queries active data and updates the in-tree runtimes files, but haven't finished it yet. So far it adds a file called 'generate_runtimes.py' to testing/runtimes, queries ActiveData and stops. If anyone wants to work on it, they can get the changeset by running: hg pull -B generate_runtimes https://hg.mozilla.org/users/ahalberstadt_mozilla.com/mozilla-central Or I can look into finishing it up too if it's a priority.
Comment 4•9 years ago
|
||
I suspect that using the existing runtimes files would be a good start and would probably fix jgriffin's issue here. Can you file a followup on finishing up that script? It would be good to have an automated process to keep the runtimes files up-to-date.
Depends on: 1142050
Summary: mochitest devtools chunks need re-normalizing → Enable chunk-by-runtime for Mochitest
Assignee | ||
Comment 5•9 years ago
|
||
How can we enable this for just devtools mochitests? I can try it on cedar.
Assignee | ||
Comment 6•9 years ago
|
||
I'm going to constrain this to devtools for the moment, where the need is highest. This will be much harder on mochitest-plain, where we don't have --chunk-by-dir already in place.
Summary: Enable chunk-by-runtime for Mochitest → Enable chunk-by-runtime for Mochitest-devtools
Assignee | ||
Comment 7•9 years ago
|
||
Enabling this on try shows green jobs for linux-debug: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef692669ba19&exclusion_profile=false However, dt3 is 77 min, close to the threshold. I've retriggered a few times to see if we hit the timeout. I suspect we need to both increase the number of chunks (bug 1165962) and enable chunk-by-runtime.
Assignee: nobody → jgriffin
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•9 years ago
|
||
I also removed some unused devtools entries.
Attachment #8612470 -
Flags: review?(ahalberstadt)
Comment 9•9 years ago
|
||
Comment on attachment 8612470 [details] [diff] [review] Enable chunk-by-runtime for mochitest-devtools, Review of attachment 8612470 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, lgtm!
Attachment #8612470 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8612470 [details] [diff] [review] Enable chunk-by-runtime for mochitest-devtools, https://hg.mozilla.org/build/mozharness/rev/01306e663846 I'll use this bug to bump the mozharness pointer in gecko as well.
Assignee | ||
Comment 11•9 years ago
|
||
mozharness bump: https://hg.mozilla.org/integration/mozilla-inbound/rev/a00dee14032f
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a00dee14032f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment 13•9 years ago
|
||
Can we please do this on Aurora as well? We hit the dt1 timeouts there pretty frequently as well.
Flags: needinfo?(jgriffin)
Assignee | ||
Comment 14•9 years ago
|
||
We'll need to bump the number of chunks, too, so I'll do that as well.
Assignee | ||
Comment 15•9 years ago
|
||
Pushed the mozharness bump to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/eb82e8c86bfe Will monitor TH for any potential bustage.
Flags: needinfo?(jgriffin)
You need to log in
before you can comment on or make changes to this bug.
Description
•