1168645 - achievements-service.js points to the wrong path for settings-utils.js

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Achievements, defect, P1)

Description

[Doug Sherk (:drs) (inactive)]

When we're using Bower to preload dependencies, they're inserted into the './components' folder. The Sharing app had some special handling for this folder -- the requirejs root was set to it, rather than the app root. Since we started building achievements-service.js with the Sharing app, I think we incorrectly assumed that the path required to import settings-utils.js from there is what would work for other apps as well.

I'm fixing these paths in the Sharing app in bug 1166044, but we should also point to './components/fxos-settings-utils/dist/settings-utils' instead of './fxos-settings-utils/dist/settings-utils' from within achievements-service.js.

Comment 1

[Doug Sherk (:drs) (inactive)]

Attachment: [achievements-service] Fix path to 'settings-utils.js' to include './components'.

Comment 2

[Doug Sherk (:drs) (inactive)]

Attachment: [settings-utils] Fix path to 'mvc.js' to include './components'.

Comment 3

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8610901 [details] [review]
[achievements-service] Fix path to 'settings-utils.js' to include './components'.

James (:jrburke) tells me that this isn't the way that we want to go, so I'm dropping the reviews and closing this.