Closed Bug 1168645 Opened 5 years ago Closed 5 years ago

achievements-service.js points to the wrong path for settings-utils.js

Categories

(Firefox OS Graveyard :: Gaia::Achievements, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: drs, Assigned: drs)

References

Details

(Whiteboard: [spark])

Attachments

(2 files)

When we're using Bower to preload dependencies, they're inserted into the './components' folder. The Sharing app had some special handling for this folder -- the requirejs root was set to it, rather than the app root. Since we started building achievements-service.js with the Sharing app, I think we incorrectly assumed that the path required to import settings-utils.js from there is what would work for other apps as well.

I'm fixing these paths in the Sharing app in bug 1166044, but we should also point to './components/fxos-settings-utils/dist/settings-utils' instead of './fxos-settings-utils/dist/settings-utils' from within achievements-service.js.
Blocks: 1166044
Attachment #8610901 - Attachment description: Fix path to 'settings-utils.js' to include './components'. → [achievements-service] Fix path to 'settings-utils.js' to include './components'.
Comment on attachment 8610901 [details] [review]
[achievements-service] Fix path to 'settings-utils.js' to include './components'.

James (:jrburke) tells me that this isn't the way that we want to go, so I'm dropping the reviews and closing this.
Attachment #8610901 - Flags: review?(yzenevich)
Attachment #8610908 - Flags: review?(yzenevich)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.