If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add result strings to PSM HPKP xpcshell tests

RESOLVED FIXED in Firefox 41

Status

()

Core
Security: PSM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
mozilla41
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8611084 [details]
MozReview Request: bz://1168695/Cykesiopka

/r/9419 - Bug 1168695 - Add result strings to PSM xpcshell HPKP tests.

Pull down this commit:

hg pull -r b0d7a84a7e3315ef952d120f8f90204ad1bfa287 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8611084 - Flags: review?(dkeeler)
Comment on attachment 8611084 [details]
MozReview Request: bz://1168695/Cykesiopka

https://reviewboard.mozilla.org/r/9417/#review8227

::: security/manager/ssl/tests/unit/test_pinning_dynamic.js:112
(Diff revision 1)
>    // add withSubdomains to a.pinning2.example.com

nit: this should be "includeSubdomains"

::: security/manager/ssl/tests/unit/test_pinning_dynamic.js:129
(Diff revision 1)
> -                                        "x.a.pinning2.example.com", 0));
> +     " withSubdomains to a.pinning2.example.com");

same: this should be includeSubdomains
Attachment #8611084 - Flags: review?(dkeeler) → review+
(Assignee)

Comment 3

2 years ago
Created attachment 8612184 [details] [diff] [review]
bug1168695_add-result-strings-pinning_v2.patch

+ Replace incorrect "withSubdomains" with correct "includeSubdomains"
Attachment #8611084 - Attachment is obsolete: true
Attachment #8612184 - Flags: review+
(Assignee)

Comment 4

2 years ago
Thanks for the review!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=484d723e6da2
Keywords: checkin-needed

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/706666a0ad01
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/706666a0ad01
https://hg.mozilla.org/mozilla-central/rev/706666a0ad01
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox41: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.