1168695 - Add result strings to PSM HPKP xpcshell tests

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Comment 1

[:Cykesiopka]

Attachment: MozReview Request: bz://1168695/Cykesiopka

/r/9419 - Bug 1168695 - Add result strings to PSM xpcshell HPKP tests.

Pull down this commit:

hg pull -r b0d7a84a7e3315ef952d120f8f90204ad1bfa287 https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8611084 [details]
MozReview Request: bz://1168695/Cykesiopka

https://reviewboard.mozilla.org/r/9417/#review8227

::: security/manager/ssl/tests/unit/test_pinning_dynamic.js:112
(Diff revision 1)
>    // add withSubdomains to a.pinning2.example.com

nit: this should be "includeSubdomains"

::: security/manager/ssl/tests/unit/test_pinning_dynamic.js:129
(Diff revision 1)
> -                                        "x.a.pinning2.example.com", 0));
> +     " withSubdomains to a.pinning2.example.com");

same: this should be includeSubdomains

Comment 3

[:Cykesiopka]

Attachment: bug1168695_add-result-strings-pinning_v2.patch

+ Replace incorrect "withSubdomains" with correct "includeSubdomains"

Comment 4

[:Cykesiopka]

Thanks for the review!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=484d723e6da2

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/706666a0ad01

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/706666a0ad01

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/706666a0ad01