[building block] smart-modal-dialog should support l10n arguments.

RESOLVED FIXED

Status

Firefox OS
Gaia::TV::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: johnhu, Assigned: johnhu)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We only have l10n id but not id with arguments.
Created attachment 8611086 [details] [review]
add l10n argument.

Sung,

This patch adds the l10n argument support. Please review it. Thanks.
Attachment #8611086 - Flags: review?(suchiu)

Comment 2

3 years ago
Comment on attachment 8611086 [details] [review]
add l10n argument.

Looks good to me!
Attachment #8611086 - Flags: review?(suchiu) → review+
merged to smart-modal-dialog:master:
https://github.com/smart-components/smart-modal-dialog/commit/0df69d851a932b890358e0eda356a74efbb4b2b4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Blocks: 1169201
No longer blocks: 1169201
You need to log in before you can comment on or make changes to this bug.