Closed
Bug 1168745
Opened 10 years ago
Closed 10 years ago
[building block] smart-modal-dialog should support l10n arguments.
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: johnhu)
References
Details
Attachments
(1 file)
We only have l10n id but not id with arguments.
|
Assignee | |
Comment 1•10 years ago
|
||
Sung,
This patch adds the l10n argument support. Please review it. Thanks.
Attachment #8611086 -
Flags: review?(suchiu)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8611086 [details] [review]
add l10n argument.
Looks good to me!
Attachment #8611086 -
Flags: review?(suchiu) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
merged to smart-modal-dialog:master:
https://github.com/smart-components/smart-modal-dialog/commit/0df69d851a932b890358e0eda356a74efbb4b2b4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•