Closed
Bug 1168769
Opened 9 years ago
Closed 9 years ago
Simplify parser's LexicalLookup function
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
6.78 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
At the moment LexicalLookup() takes a slotp out parameter which if set is populated with the slot index of the name found. However this is never used.
Attachment #8611114 -
Flags: review?(jwalden+bmo)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8611114 [details] [diff] [review] simplify-lexical-lookup Review of attachment 8611114 [details] [diff] [review]: ----------------------------------------------------------------- But but but that slotp outparam was so useful, we used it everywhere! ::: js/src/frontend/SharedContext.h @@ +553,2 @@ > * scope chain must have had their depth slots computed by the code generator, > * so the caller must be under EmitTree. Remove the slotp references in this comment. Also fix the |sc| mention here, which is probably |ct| now, I guess.
Attachment #8611114 -
Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/8e0cdd01b165
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•