[B2G] Update profile for the new profile json file format

RESOLVED FIXED in Firefox 41

Status

()

P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: wcosta, Assigned: ting)

Tracking

Trunk
mozilla41
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Bug 1154115 changed the json file format for profile data.
(Reporter)

Updated

4 years ago
OS: Unspecified → Gonk (Firefox OS)
Hardware: Unspecified → All
Version: unspecified → Trunk
What's this with regard to? Update which profile? Any additional information necessary for the dev tools team?
(Assignee)

Comment 3

4 years ago
Also need to update: https://hg.mozilla.org/mozilla-central/file/f986e55c4e0b/tools/profiler/merge-profiles.py

I'll take it if no one is working on this.
(In reply to Ting-Yu Chou [:ting] from comment #3)
> Also need to update:
> https://hg.mozilla.org/mozilla-central/file/f986e55c4e0b/tools/profiler/
> merge-profiles.py
> 
> I'll take it if no one is working on this.

Great! I have not started on anything yet. Shu pointed out the new format is documented in the ProfileEntry header [1].

I believe all we need to do is process the |stringTable| array. Also we'll want to maintain backwards compatibility (the meta.version was bumped from 2 to 3, so this is easy to detect).

[1] https://dxr.mozilla.org/mozilla-central/source/tools/profiler/ProfileEntry.h#271-362
(Assignee)

Comment 5

4 years ago
(In reply to Eric Rahm [:erahm] from comment #4)
> I believe all we need to do is process the |stringTable| array. Also we'll
> want to maintain backwards compatibility (the meta.version was bumped from 2
> to 3, so this is easy to detect).

Thanks for reminding, I'll do it on Monday :)
Assignee: nobody → janus926
Status: NEW → ASSIGNED

Comment 6

4 years ago
(In reply to Eric Rahm [:erahm] from comment #4)
> (In reply to Ting-Yu Chou [:ting] from comment #3)
> > Also need to update:
> > https://hg.mozilla.org/mozilla-central/file/f986e55c4e0b/tools/profiler/
> > merge-profiles.py
> > 
> > I'll take it if no one is working on this.
> 
> Great! I have not started on anything yet. Shu pointed out the new format is
> documented in the ProfileEntry header [1].
> 
> I believe all we need to do is process the |stringTable| array. Also we'll
> want to maintain backwards compatibility (the meta.version was bumped from 2
> to 3, so this is easy to detect).

If all you care about is symbolication of 0xF00 address, then yeah, looks like stringTable is all you need. May speed it up too, since the table is of unique strings only.
(Assignee)

Comment 7

4 years ago
Created attachment 8613466 [details] [diff] [review]
Part 1: Fix the script merging profiles to handle new profiler JSON format
Attachment #8613466 - Flags: review?(bgirard)
(Assignee)

Comment 8

4 years ago
Created attachment 8613467 [details] [review]
Part 2: Fix the script searching unresolved addresses to handle new profiler JSON format
Attachment #8613467 - Flags: review?(dhylands)
Attachment #8613466 - Flags: review?(bgirard) → review+
Comment on attachment 8613467 [details] [review]
Part 2: Fix the script searching unresolved addresses to handle new profiler JSON format

Looks good to me. I like the use of a generator (I didn't know about those when I wrote the original code)
Attachment #8613467 - Flags: review?(dhylands) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fcc5f6cc417a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(Reporter)

Updated

4 years ago
See Also: → bug 1171581
You need to log in before you can comment on or make changes to this bug.