Closed Bug 1168784 Opened 6 years ago Closed 6 years ago

[B2G] Update profile for the new profile json file format

Categories

(Core :: Gecko Profiler, defect, P1)

All
Gonk (Firefox OS)
defect

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: wcosta, Assigned: ting)

References

Details

Attachments

(2 files)

Bug 1154115 changed the json file format for profile data.
OS: Unspecified → Gonk (Firefox OS)
Hardware: Unspecified → All
Version: unspecified → Trunk
What's this with regard to? Update which profile? Any additional information necessary for the dev tools team?
Also need to update: https://hg.mozilla.org/mozilla-central/file/f986e55c4e0b/tools/profiler/merge-profiles.py

I'll take it if no one is working on this.
(In reply to Ting-Yu Chou [:ting] from comment #3)
> Also need to update:
> https://hg.mozilla.org/mozilla-central/file/f986e55c4e0b/tools/profiler/
> merge-profiles.py
> 
> I'll take it if no one is working on this.

Great! I have not started on anything yet. Shu pointed out the new format is documented in the ProfileEntry header [1].

I believe all we need to do is process the |stringTable| array. Also we'll want to maintain backwards compatibility (the meta.version was bumped from 2 to 3, so this is easy to detect).

[1] https://dxr.mozilla.org/mozilla-central/source/tools/profiler/ProfileEntry.h#271-362
(In reply to Eric Rahm [:erahm] from comment #4)
> I believe all we need to do is process the |stringTable| array. Also we'll
> want to maintain backwards compatibility (the meta.version was bumped from 2
> to 3, so this is easy to detect).

Thanks for reminding, I'll do it on Monday :)
Assignee: nobody → janus926
Status: NEW → ASSIGNED
(In reply to Eric Rahm [:erahm] from comment #4)
> (In reply to Ting-Yu Chou [:ting] from comment #3)
> > Also need to update:
> > https://hg.mozilla.org/mozilla-central/file/f986e55c4e0b/tools/profiler/
> > merge-profiles.py
> > 
> > I'll take it if no one is working on this.
> 
> Great! I have not started on anything yet. Shu pointed out the new format is
> documented in the ProfileEntry header [1].
> 
> I believe all we need to do is process the |stringTable| array. Also we'll
> want to maintain backwards compatibility (the meta.version was bumped from 2
> to 3, so this is easy to detect).

If all you care about is symbolication of 0xF00 address, then yeah, looks like stringTable is all you need. May speed it up too, since the table is of unique strings only.
Attachment #8613466 - Flags: review?(bgirard) → review+
Comment on attachment 8613467 [details] [review]
Part 2: Fix the script searching unresolved addresses to handle new profiler JSON format

Looks good to me. I like the use of a generator (I didn't know about those when I wrote the original code)
Attachment #8613467 - Flags: review?(dhylands) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fcc5f6cc417a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
See Also: → 1171581
You need to log in before you can comment on or make changes to this bug.